Remove SQLite integration in favor of an ORM for a DB agnostic implementation - #9
Open
David-bfg wants to merge 8 commits into
Open
Remove SQLite integration in favor of an ORM for a DB agnostic implementation#9David-bfg wants to merge 8 commits into
David-bfg wants to merge 8 commits into
Conversation
added a model file of the SQL schema replaced SQLite integration with SQLAlchemy ORM code ported and simplified will allows app to be DB agnostic eventually
A full refactor of the main file that scrapes data. SQLite is out and SQLAlchemy is in. Improved code simplicity and removing around 90 LOC. DB model has also been extended to implement filtered jobs and include some additional default values.
Bug found in API target that was not used derectly by the web app
Found syntax typos, rewrote to pass in attributes during object creation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored-removed SQLite in favor of SQLAlchemy an ORM Database solution.
Will allow project to easily extend to other supported databases beyond just SQLite such as one running out on a server.
Note: significantly more confident on app.py because I don't want to get my IP blocked or banned by running main.py.
Thus main.py requires some testing-code review beyond a quick LGTM.