Open
Conversation
ismarc
force-pushed
the
conjur-tracing-no-middleware
branch
from
172785b to
c93f6a3
Compare
aacastillo
force-pushed
the
conjur-tracing-no-middleware
branch
from
c93f6a3 to
d1bfecc
Compare
aacastillo
force-pushed
the
conjur-tracing-no-middleware
branch
2 times, most recently
from
a607a00 to
ac46639
Compare
|
Code Climate has analyzed commit ac46639 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 33.3% (50% is the threshold). This pull request will bring the total coverage in the repository to 87.9% (-1.5% change). View more on Code Climate. |
Added feature flag with config system. Tracing in controllers are inehrited from application controller. Rack middleware removed, does NOT receive context propagation. Moved tracing logic to concern.
aacastillo
force-pushed
the
conjur-tracing-no-middleware
branch
from
a169899 to
35f6614
Compare
Contributor
|
I'm curious why this was never merged. @cyberark/conjur-core-team? |
conjur-jenkins
force-pushed
the
master
branch
2 times, most recently
from
6566647 to
d65d499
Compare
conjur-jenkins
force-pushed
the
master
branch
from
d65d499 to
dbea020
Compare
conjur-jenkins
force-pushed
the
master
branch
from
dbea020 to
8031a2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desired Outcome
The desired outcome for this PR is add observability tracing into Conjur.
Implemented Changes
The incoming changes add the Open Telemetry ruby gem to add traces into the codebase and to send these traces to a specified Jaeger container. The changes include an all-in-one Jaeger container in the docker-compose file which can be boot up using a feature flag that has been added to the start script.
Connected Issue/Story
CyberArk internal issue link: insert issue ID
Definition of Done
At least 1 todo must be completed in the sections below for the PR to be
merged.
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
READMEs) were updated in this PRBehavior
Security