Adds authenticator support for passing OIDC token via body or authorization header#2634
Draft
jvanderhoof wants to merge 3 commits intomasterfrom
Draft
Adds authenticator support for passing OIDC token via body or authorization header#2634jvanderhoof wants to merge 3 commits intomasterfrom
jvanderhoof wants to merge 3 commits intomasterfrom
Conversation
This commit adds support for passing an OIDC identity token via POST body or POST Authorization header
rafis3
reviewed
Aug 24, 2022
| ) do |authenticator| | ||
| Authentication::AuthnOidc::V2::Strategies::Token.new( | ||
| authenticator: authenticator | ||
| ).callback(request.authorization.to_s.split(' ').last || request.raw_post) |
Member
There was a problem hiding this comment.
I think we should verify that the first value of the split is "Bearer" and not just any word. To enforce the correct standard. WDYT?
…ell as V1 OIDC Auth support in V2
conjur-jenkins
force-pushed
the
master
branch
2 times, most recently
from
6566647 to
d65d499
Compare
conjur-jenkins
force-pushed
the
master
branch
from
d65d499 to
dbea020
Compare
conjur-jenkins
force-pushed
the
master
branch
from
dbea020 to
8031a2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desired Outcome
Please describe the desired outcome for this PR. Said another way, what was
the original request that resulted in these code changes? Feel free to copy
this information from the connected issue.
Implemented Changes
Describe how the desired outcome above has been achieved with this PR. In
particular, consider:
Connected Issue/Story
Resolves #[relevant GitHub issue(s), e.g. 76]
CyberArk internal issue link: insert issue ID
Definition of Done
At least 1 todo must be completed in the sections below for the PR to be
merged.
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
READMEs) were updated in this PRBehavior
Security