V0.14.0 fixes #47
V0.14.0 fixes #47
Conversation
truman-cyborg
requested review from
ahellegit and
dupontcyborg
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ API Contract Change Detected
This PR modifies the public API contract of the CyborgDB JS SDK.
Please provide an explanation for this change:
- Why is this change necessary?
- Is this a breaking change or backward compatible?
- Have you updated the documentation?
This review must be dismissed or addressed before the PR can be merged.
src/__tests__/api_contract.test.ts
Outdated
| // Contents should be decoded to string by SDK | ||
| expect(typeof result.contents).toBe('string'); | ||
| // Contents for the ids were upserted as buffer object | ||
| expect(typeof result.contents).toBe('object'); |
There was a problem hiding this comment.
The Python SDK expects contents to be returned as a string, even when uploaded as bytes but for JS now we are expecting it to be as raw buffer object? I think we should have consistent behavior across both sdks, having text content is more user friendly
There was a problem hiding this comment.
revert it back for now
the changes were to reduce the amount of failed test when running them and to fix one bug for upsert. |
There was a problem hiding this comment.
bug fix for upsert if we upsert without vector but also include a context
added better error handling for upsert and update the test to be more accurate to what we're upserting