-
-
Notifications
You must be signed in to change notification settings - Fork 0
fix: observation timestamp normalization to float8 #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,15 @@ | ||
| # LOC Metrics | ||
|
|
||
| _Generated: Wed Jul 8 03:16:41 PM EDT 2026 | SHA: 09474d14_ | ||
| _Generated: Wed Jul 8 05:58:18 PM EDT 2026 | SHA: 2ff30228_ | ||
|
|
||
| | cloc | github.com/AlDanial/cloc v 2.06 T=3.99 s (462.8 files/s, 161808.9 lines/s) | | ||
| | cloc | github.com/AlDanial/cloc v 2.06 T=4.35 s (425.1 files/s, 148577.8 lines/s) | | ||
| | ---- | -------------------------------------------------------------------------- | | ||
|
|
||
| | Language | files | blank | comment | code | | ||
| | :--------- | -------: | -------: | -------: | -------: | | ||
| | SQL | 340 | 4533 | 6245 | 414867 | | ||
| | TypeScript | 1474 | 24231 | 8284 | 182592 | | ||
| | TypeScript | 1475 | 24245 | 8301 | 182694 | | ||
| | JavaScript | 32 | 486 | 237 | 3908 | | ||
| | CSS | 1 | 47 | 27 | 276 | | ||
| | -------- | -------- | -------- | -------- | -------- | | ||
| | SUM: | 1847 | 29297 | 14793 | 601643 | | ||
| | SUM: | 1848 | 29311 | 14810 | 601745 | |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -70,15 +70,15 @@ const validateWigleNetworksQuery = validateQuery({ | |
| * the wigle_networks_enriched view for v2-only imports. | ||
| */ | ||
| router.get( | ||
| '/page/network/:netid', | ||
| '/page/network/:bssid', | ||
| macParamMiddleware, | ||
| asyncHandler(async (req: Request, res: Response) => { | ||
| const { netid } = req.params; | ||
| const { bssid } = req.params; | ||
| // Try MV first (single-row read); fall back to live 4-query fan-out if MV | ||
| // is unavailable (pre-migration deployment) or returns no row. | ||
| let network = await wigleService.getWiglePageNetworkFromMv(netid); | ||
| let network = await wigleService.getWiglePageNetworkFromMv(bssid); | ||
| if (!network) { | ||
| network = await wigleService.getWiglePageNetwork(netid); | ||
| network = await wigleService.getWiglePageNetwork(bssid); | ||
|
Comment on lines
+73
to
+81
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win Cross-file contract drift: param rename not propagated to client config, docs, or route inventory. The route param rename from
Per coding guidelines, every endpoint requires an entry in As per coding guidelines: "Every new endpoint requires: entry in 🤖 Prompt for AI AgentsSource: Coding guidelines
Comment on lines
+73
to
+81
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 1. api_endpoints still uses :netid The WiGLE DB page route parameter was renamed from :netid to :bssid, but the Admin API Testing endpoint registry/preset still references the old :netid path. This leaves the testing UI out of sync with the backend and causes Bulk Endpoint Verification to generate non-matching/invalid URLs that consistently fail MAC validation, violating the compliance requirement to register modified API routes. Agent Prompt
|
||
| } | ||
| if (!network) { | ||
| return res.status(404).json({ error: 'Network not found in WiGLE database' }); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: The route param was renamed from
:netidto:bssidhere, but the corresponding references inclient/src/config/apiTestEndpoints.ts,docs/API_REFERENCE.md,docs/api/route-inventory.md, andtests/unit/wigleDatabase.test.tsstill use:netid. While the URL path itself is unchanged (so clients still work), the inconsistency across the codebase will confuse future maintainers and may cause test/config mismatches if someone searches by param name.Prompt for AI agents