Refactor/sp address without network - #148
Open
Sosthene00 wants to merge 4 commits into
Open
Conversation
The example duplicated the documented usage and is superseded by the SilentPaymentAddress/SilentPaymentAddressDisplay split. Co-authored-by: Cursor <cursoragent@cursor.com>
… from version() Rename SilentPaymentAddress::get_scan_key/get_spend_key/get_network/get_version to scan_key/spend_key/network/version, and change version() to return SpVersion instead of u8. Update all call sites. Co-authored-by: Cursor <cursoragent@cursor.com>
Fix typo in version error message, replace match with if/else in NonEmptyArray::new, and use expect() with messages instead of unwrap() in bech32 encoding. Co-authored-by: Cursor <cursoragent@cursor.com>
Remove the network from `SilentPaymentAddress` and isolate the whole display logic in a new `SilentPaymentAddressDisplay` type. Add byte-array constructors/serialization and network-agnostic constructors to `SilentPaymentAddress`. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace #137
I propose to remove the network part of
SilentPaymentAddressand have anotherSilentPaymentAddressDisplaytype gated behind encode handle the stringification separately.