lib/gis: solve write out conflicts of G_Percent/G_Progress when multithreading

.dockerignore

@@ -6,7 +6,7 @@ docker
 # Do not copy files from previous compilations
 dist.*
 
-# The following git files are needed by GRASS GIS to extract the revision
+# The following git files are needed by GRASS to extract the revision
 # during compilation. If you are not using one of the Dockerimages from this
 # repository, delete the .git folder in your Dockerfile after compilation.
 .git

.flake8

@@ -20,7 +20,6 @@ per-file-ignores =
     # E722 do not use bare 'except'
     # W605 invalid escape sequence
     # F821 undefined name 'unicode'
-    # F841 local variable assigned to but never used
     # E741 ambiguous variable name 'l'
     man/build_html.py: E501
     man/build_md.py: E501

.github/ISSUE_TEMPLATE/bug_report.md

@@ -28,10 +28,10 @@ assignees: ''
 ## System description
 <!--
 - Operating System: [e.g. Windows, Linux, ..., incl. version]
-- GRASS GIS version: [e.g. 4.0]
+- GRASS version: [e.g. 4.0]
 
 - details about further software components
-    - run `g.version -rge` in a GRASS GIS terminal session or check in
+    - run `g.version -rge` in a GRASS terminal session or check in
       the GUI menu "Help > About"
     - run `python3 -c "import sys, wx; print(sys.version); print(wx.version())"`
       to print the Python and wxPython version numbers

.github/actionlint.yaml

@@ -0,0 +1,23 @@
+---
+self-hosted-runner:
+  # Labels of self-hosted runner in array of strings.
+  labels: []
+
+# Configuration variables in array of strings defined in your repository or
+# organization. `null` means disabling configuration variables check.
+# Empty array means no configuration variable is allowed.
+config-variables: null
+
+# Configuration for file paths. The keys are glob patterns to match to file
+# paths relative to the repository root. The values are the configurations for
+# the file paths. Note that the path separator is always '/'.
+# The following configurations are available.
+#
+# "ignore" is an array of regular expression patterns. Matched error messages
+# are ignored. This is similar to the "-ignore" command line option.
+paths:
+  # .github/workflows/**/*.yml:
+  #   ignore: []
+  .github/workflows/python-code-quality.yml:
+    ignore:
+      - 'condition "false" is always evaluated to false. remove the if: section' # [if-cond]

.github/actions/create-upload-suggestions/action.yml

@@ -145,7 +145,9 @@ runs:
     - name: List all changed files tracked and untracked files
       shell: bash
       run: |
-        echo "Changed files: ${{ steps.git-changed-files.outputs.CHANGED_FILES }}"
+        echo "Changed files: ${CHANGED_FILES}"
+      env:
+        CHANGED_FILES: ${{ steps.git-changed-files.outputs.CHANGED_FILES }}
     - name: Add job summary without changed files
       shell: bash
       if: ${{ steps.files_changed.outputs.files_changed == 'false' }}
@@ -177,7 +179,7 @@ runs:
         echo "diff-file-name=${INPUT_DIFF_FILE_NAME}" >> "${GITHUB_OUTPUT}"
       env:
         INPUT_DIFF_FILE_NAME: ${{ steps.tool-name-safe.outputs.diff-file-name }}
-    - uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
+    - uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
       id: upload-diff
       if: >-
         ${{ (steps.files_changed.outputs.files_changed == 'true') &&
@@ -200,7 +202,7 @@ runs:
           echo 'Suggestions can only be added near to lines changed in this PR.'
           echo 'If any fixes can be added as code suggestions, they will be added shortly from another workflow.'
         } >> "${GITHUB_STEP_SUMMARY}"
-    - uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
+    - uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
       id: upload-changes
       if: >-
         ${{ always() &&

.github/workflows/additional_checks.yml

@@ -23,19 +23,26 @@ jobs:
   additional-checks:
     name: Additional checks
     runs-on: ubuntu-24.04
+    permissions:
+      contents: read
 
     steps:
       - name: Checkout repository contents
-        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+        uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0
         with:
           fetch-depth: 31
+          persist-credentials: false
 
       - name: Set up Python
-        uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
+        uses: actions/setup-python@83679a892e2d95755f2dac6acb0bfd1e9ac5d548 # v6.1.0
         with:
-          python-version: "3.13"
+          python-version: "3.14"
       - name: Install uv and restore its cache
-        uses: astral-sh/setup-uv@e92bafb6253dcd438e0484186d7669ea7a8ca1cc # v6.4.3
+        uses: astral-sh/setup-uv@1e862dfacbd1d6d858c55d9b792c756523627244 # v7.1.4
+        with:
+          # To not have the last commit JSON and release notes files affected on
+          # releases, if copying the contents displayed in the CI logs.
+          enable-cache: false
 
       - name: Check that files with the same content are the same
         run: |
@@ -55,11 +62,12 @@ jobs:
           # Using the last 30 commits (for branches, tags, and PRs).
           # End is the current (latest) commit.
           python ./utils/generate_release_notes.py log \
-              ${{ github.ref_name }} \
-              $(git rev-parse HEAD~30) \
+              "${GITHUB_REF_NAME}" \
+              "$(git rev-parse HEAD~30)" \
               ""
       - name: "Cache pre-commit"
-        uses: actions/cache@5a3ec84eff668545956fd18022155c47e93e2684 # v4.2.3
+        # Not used for releases, only for running pre-commit
+        uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0  # zizmor: ignore[cache-poisoning]
         with:
           path: ~/.cache/pre-commit
           key: pre-commit-${{ hashFiles('.pre-commit-config.yaml') }}

.github/workflows/apt.txt

@@ -8,6 +8,7 @@ libgdal-dev
 libgl1-mesa-dev
 libglu1-mesa-dev
 liblapacke-dev
+libncurses-dev
 libnetcdf-dev
 libpdal-dev
 libpng-dev

.github/workflows/build_osgeo4w.sh

@@ -4,7 +4,7 @@
 #
 # By default, the script will look for the source code in the current directory
 # and create bin.x86_64-w64-mingw32\grass$ver.bat (run this batch file to start
-# GRASS GIS) and dist.x86_64-w64-mingw32\etc\env.bat.
+# GRASS) and dist.x86_64-w64-mingw32\etc\env.bat.
 #
 # path	specify a path to the source code
 #

.github/workflows/build_ubuntu-24.04.sh

@@ -0,0 +1,56 @@
+#!/usr/bin/env bash
+
+# The make step requires something like:
+# export LD_LIBRARY_PATH="$LD_LIBRARY_PATH:$PREFIX/lib"
+# further steps additionally require:
+# export PATH="$PATH:$PREFIX/bin"
+
+# fail on non-zero return code from a subprocess
+set -e
+
+# print commands
+set -x
+
+if [ -z "$1" ]; then
+    echo "Usage: $0 PREFIX"
+    exit 1
+fi
+
+# Adding -Werror to make's CFLAGS is a workaround for configuring with
+# an old version of configure, which issues compiler warnings and
+# errors out. This may be removed with upgraded configure.in file.
+makecmd="make"
+if [[ "$#" -ge 2 ]]; then
+    ARGS=("$@")
+    makecmd="make CFLAGS='$CFLAGS ${ARGS[@]:1}' CXXFLAGS='$CXXFLAGS ${ARGS[@]:1}'"
+fi
+
+# non-existent variables as an errors
+set -u
+
+export INSTALL_PREFIX=$1
+
+./configure \
+    --enable-largefile \
+    --prefix="$INSTALL_PREFIX/" \
+    --with-blas \
+    --with-bzlib \
+    --with-cxx \
+    --with-fftw \
+    --with-freetype \
+    --with-freetype-includes="/usr/include/freetype2/" \
+    --with-geos \
+    --with-lapack \
+    --with-libsvm \
+    --with-netcdf \
+    --with-openmp \
+    --with-pdal \
+    --with-proj-share=/usr/share/proj \
+    --with-pthread \
+    --with-readline \
+    --with-sqlite \
+    --with-tiff \
+    --with-zstd
+
+eval $makecmd
+make install

.github/workflows/build_ubuntu-24.04_without_x.sh

@@ -0,0 +1,54 @@
+#!/usr/bin/env bash
+
+# The make step requires something like:
+# export LD_LIBRARY_PATH="$LD_LIBRARY_PATH:$PREFIX/lib"
+# further steps additionally require:
+# export PATH="$PATH:$PREFIX/bin"
+
+# fail on non-zero return code from a subprocess
+set -e
+
+# print commands
+set -x
+
+if [ -z "$1" ]; then
+    echo "Usage: $0 PREFIX"
+    exit 1
+fi
+
+# Adding -Werror to make's CFLAGS is a workaround for configuring with
+# an old version of configure, which issues compiler warnings and
+# errors out. This may be removed with upgraded configure.in file.
+makecmd="make"
+if [[ "$#" -eq 2 ]]; then
+    makecmd="make CFLAGS='$CFLAGS $2' CXXFLAGS='$CXXFLAGS $2'"
+fi
+
+# non-existent variables as an errors
+set -u
+
+export INSTALL_PREFIX=$1
+
+./configure \
+    --enable-largefile \
+    --prefix="$INSTALL_PREFIX/" \
+    --without-blas \
+    --without-lapack \
+    --with-bzlib \
+    --with-cxx \
+    --with-fftw \
+    --with-freetype \
+    --with-freetype-includes="/usr/include/freetype2/" \
+    --with-geos \
+    --with-netcdf \
+    --with-pdal \
+    --with-proj-share=/usr/share/proj \
+    --with-readline \
+    --with-sqlite \
+    --with-tiff \
+    --with-zstd \
+    --without-openmp \
+    --without-pthread
+
+eval $makecmd
+make install

.github/workflows/clang-format-check.yml

@@ -16,7 +16,7 @@ jobs:
     name: Formatting Check
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+      - uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0
         with:
           persist-credentials: false
       - uses: DoozyX/clang-format-lint-action@c71d0bf4e21876ebec3e5647491186f8797fde31 # v0.18.2

.github/workflows/cmake.yml

@@ -24,28 +24,32 @@ permissions:
 
 jobs:
   build-cmake:
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     env:
-      CMakeVersion: "3.22.0"
+      CMAKE_VERSION: "3.22.0"
     steps:
       - name: Checkout GRASS
-        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+        uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0
+        with:
+          persist-credentials: false
       - name: Install CMake
         run: |
-          cd ${GITHUB_WORKSPACE}
-          arch=$(echo $(uname -s)-$(uname -m) | awk '{print tolower($0)}')
-          v=v${{ env.CMakeVersion }}/cmake-${{ env.CMakeVersion }}-${arch}.tar.gz
-          wget https://github.com/Kitware/CMake/releases/download/$v
-          tar xzf cmake-${{ env.CMakeVersion }}-${arch}.tar.gz
-          echo "CMAKE_DIR=$GITHUB_WORKSPACE/cmake-${{ env.CMakeVersion }}-${arch}/bin" >> $GITHUB_ENV
-          echo "$GITHUB_WORKSPACE/cmake-${{ env.CMakeVersion }}-${arch}/bin" >> $GITHUB_PATH
+          cd "${GITHUB_WORKSPACE}" || exit
+          arch="$(echo "$(uname -s)"-"$(uname -m)" | awk '{print tolower($0)}')"
+          v="v${CMAKE_VERSION}/cmake-${CMAKE_VERSION}-${arch}.tar.gz"
+          wget "https://github.com/Kitware/CMake/releases/download/$v"
+          tar xzf "cmake-${CMAKE_VERSION}-${arch}.tar.gz"
+          echo "CMAKE_DIR=${GITHUB_WORKSPACE}/cmake-${CMAKE_VERSION}-${arch}/bin" >> "${GITHUB_ENV}"
+          echo "${GITHUB_WORKSPACE}/cmake-${CMAKE_VERSION}-${arch}/bin" >> "${GITHUB_PATH}"
       - run: |
           cmake --version
       - name: Install dependencies
         run: |
           sudo apt-get update -y
           sudo apt-get install -y wget git gawk findutils ninja-build libpq-dev \
             gettext unixodbc-dev libnetcdf-dev
+          LC_ALL=C.UTF-8 sudo add-apt-repository -y ppa:ubuntugis/ubuntugis-unstable
+          sudo apt-get update -y
           xargs -a <(awk '! /^ *(#|$)/' ".github/workflows/apt.txt") -r -- \
               sudo apt-get install -y --no-install-recommends --no-install-suggests
       - name: Print build environment variables
@@ -56,25 +60,25 @@ jobs:
           ldd --version
       - name: Create installation directory
         run: |
-          mkdir $HOME/install
+          mkdir "${HOME}/install"
       - name: Configure
         run: |
-          cmake ${CMAKE_OPTIONS} -S $GITHUB_WORKSPACE -B $GITHUB_WORKSPACE/build -G Ninja \
-            -DCMAKE_INSTALL_PREFIX=$HOME/install -DWITH_NLS=ON -DWITH_GUI=OFF -DWITH_DOCS=OFF \
+          cmake -S "${GITHUB_WORKSPACE}" -B "${GITHUB_WORKSPACE}/build" -G Ninja \
+            -DCMAKE_INSTALL_PREFIX="${HOME}/install" -DWITH_NLS=ON -DWITH_GUI=OFF -DWITH_DOCS=OFF \
             -DWITH_READLINE=ON -DWITH_ODBC=ON -DWITH_NETCDF=ON -DWITH_BZLIB=ON
       - name: Print CMakeCache.txt
         shell: bash -el {0}
         run: |
-          cat ${GITHUB_WORKSPACE}/build/CMakeCache.txt
+          cat "${GITHUB_WORKSPACE}/build/CMakeCache.txt"
       - name: Build
         run: |
-          cmake --build build --verbose -j$(nproc)
+          cmake --build build --verbose -j"$(nproc)"
       - name: Install
         run: |
-          cmake --install $GITHUB_WORKSPACE/build --verbose
+          cmake --install "${GITHUB_WORKSPACE}/build" --verbose
       - name: Add the bin directory to PATH
         run: |
-          echo "$HOME/install/bin" >> $GITHUB_PATH
+          echo "${HOME}/install/bin" >> "${GITHUB_PATH}"
       - name: Print installed versions
         if: always()
         run: .github/workflows/print_versions.sh
@@ -84,7 +88,7 @@ jobs:
         run: .github/workflows/test_thorough.sh --config .gunittest.cfg --min-success 98
       - name: Make HTML test report available
         if: ${{ !cancelled() }}
-        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
+        uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
         with:
           name: testreport-CMake
           path: testreport