fix(vcf): return (filter, pl_filter) tuple from VCF.filter getter#54
Merged
Conversation
The getter returned only the cyvcf2 callable while the setter accepted a (filter, pl_filter) tuple, so vcf.filter = vcf.filter did not round-trip. Return both as a tuple ((None, None) when unset) to mirror the setter. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VCF.filter's getter returned only the cyvcf2 callable while the setter accepted a(filter, pl_filter)tuple, sovcf.filter = vcf.filterdid not round-trip. The getter now returns both as a tuple ((None, None)when unset), mirroring the setter.Changes
genoray/_vcf.py— getter returns(filter, pl_filter).tests/test_vcf.py— assertions updated to the tuple shape + a round-trip check.skills/genoray-api/SKILL.md— getter description updated (public API change).Breaking note
The getter no longer returns a bare callable, so external code doing
if vcf.filter:orvcf.filter(variant)would break. Nothing in the repo besides the one test relied on the old shape.🤖 Generated with Claude Code