Skip to content

ci: CodeQL PR file coverage + screenshots workflow Node 24#105

Merged
d0dg3r merged 1 commit intomainfrom
chore/workflows-codeql-coverage-node24
Apr 6, 2026
Merged

ci: CodeQL PR file coverage + screenshots workflow Node 24#105
d0dg3r merged 1 commit intomainfrom
chore/workflows-codeql-coverage-node24

Conversation

@d0dg3r
Copy link
Copy Markdown
Owner

@d0dg3r d0dg3r commented Apr 6, 2026

Summary

Implements the workflow refresh plan:

  • CodeQL — Set CODEQL_ACTION_FILE_COVERAGE_ON_PRS=true so PR analyses keep computing file coverage after GitHub's April 2026 default (performance trade-off: slightly slower PR CodeQL runs).
  • Generate Store Screenshots — Add FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true for parity with CI, manual-build, release, and CodeQL workflows.

Other Actions pins were already current (checkout/setup-node v6, upload-artifact v7, download-artifact v8, codeql-action v4); Dependabot continues weekly github-actions updates.

Verify

After merge, confirm CodeQL on a PR shows expected behavior and no unexpected annotations.

- Set CODEQL_ACTION_FILE_COVERAGE_ON_PRS=true so PR analyses keep file coverage
  after GitHub's April 2026 default change (slightly slower PR runs).
- Add FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 to screenshots workflow for parity.
Copilot AI review requested due to automatic review settings April 6, 2026 23:33
@d0dg3r d0dg3r merged commit 733d8d4 into main Apr 6, 2026
4 of 5 checks passed
@d0dg3r d0dg3r deleted the chore/workflows-codeql-coverage-node24 branch April 6, 2026 23:34
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates GitHub Actions workflows to maintain consistent JavaScript action runtime behavior (Node 24) and preserve CodeQL PR file coverage after GitHub’s April 2026 default change.

Changes:

  • Enable PR file coverage in CodeQL runs by setting CODEQL_ACTION_FILE_COVERAGE_ON_PRS=true.
  • Add FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true to the screenshots workflow for parity with other workflows.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/screenshots.yml Adds Node 24 JS-actions runtime env flag at workflow level.
.github/workflows/codeql.yml Forces CodeQL PR file coverage and keeps Node 24 JS-actions runtime flag.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants