Repository navigation
Fix README packaging and verify automatic CSDID releases - #87
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
pedrohcgs
marked this pull request as draft
October 27, 2026 21:42
pedrohcgs
marked this pull request as ready for review
October 27, 2026 21:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README bot uses an outdated
README.qmdthat changes the Python package name fromcsdidtodidand drops badges, aggregation examples and citation instructions. TrackedREADME.md/readme.mdaliases also collide on macOS, while packaging and Quarto read different paths. The PyPI publisher also needs public readback: a cached preflight 404 followed byskip-existingcan report a successful upload without proving that the published artifacts match the reviewed source or are visible to installers.This PR fixes the README source and packaging, and requires verified public artifacts before a release or an existing-release retry succeeds. It includes main
d5123fband prepares CSDID 0.4.5, because the canonical README changessetup.pyandMANIFEST.in; reusing 0.4.4 would conflict with immutable published build inputs. The exactdrdid==1.1.7requirement, reviewed peer lock and estimator logic remain unchanged.Changes:
README.md, the package name, six badges, event-study/overall examples, newer options and citation. Use checked-in example data, fixed seeds and pinned rendering dependencies; render twice and allow the bot to commit only generated Markdown and PNGs.Validation on
9fd65c6:pip checkpasses.twine check, identifycsdid, require exactly DRDID 1.1.7, and contain the canonical README bytes as their UTF-8 long descriptions. The sdist contains only the canonical README path. Production archive validators accept the built source, build inputs and dependencies.560d0c9. The earlier authentic render/build hashes were checked against the saved files and retained; the receipt records a separate integrated-check timestamp.Evidence: current validation receipt, preserved 0.4.4 receipt, render replay instructions, and publication guarantees and retry limits.
All three required checks passed on final head
9fd65c6: Python 3.8 and 3.12 and current R parity. Merged aseb9d3204bffdd62de836197e1f347f4b51b946d6; all three required main checks also passed. Feature-branch README previews skip bot PR publication. Main retains automatic README PR creation throughGITHUB_TOKEN; generated PRs still need the mandatory CI checks before merging. PyPI uploads are not atomic, and client-side verification cannot prevent a later owner action from changing availability.Activation verified: CSDID 0.4.5 published automatically in run 40592679312. The earlier R-completion event correctly skipped publication while the main CI workflow remained incomplete. The later CI event published after all three checks passed; the new public readback recovered from two real HTTP 404 responses with 5s and 10s waits, then verified both artifacts and the public installer index. No manual dispatch or rerun was needed.
Both public artifacts pass exact merged-source/build-input/metadata/SHA256 checks, require
drdid==1.1.7, and carry the canonical README. A fresh isolated public-only install resolved CSDID 0.4.5 plus DRDID 1.1.7, passed pip check, and produced the expected pre/post ATT 0/2 in one minimal regression-panel smoke test. The real main README bot also passed all 41 guards and reproducible rendering; its generated PR #90 changes only three PNGs, preserving README text and package identity.Separate nonmandatory issue: Dependency Graph run 40591709755 fails because Dependabot selects Python 3.8 from the legacy Pipfile while its scanner supports 3.10–3.14. This does not authorize or bypass any required CI/release check. No legacy Pipenv migration or Python support change is included here.