Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions .github/workflows/pages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,14 @@ name: Deploy web flasher
# would expose a vX.Y.Z build's binaries through the flasher while the
# release itself is still a draft, defeating the point of drafting it
# (docs/ROADMAP.md: tagging is "a separate, deliberate step").
#
# No `environment:` block on the deploy job: release events run on the tag
# ref (refs/tags/vX.Y.Z), and the repo's github-pages environment protection
# rules only allow branch refs — the tag is rejected before any step runs
# ("Tag vX.Y.Z is not allowed to deploy to github-pages"). Removing the
# block skips the protection-rule check; deploy-pages still publishes to
# the same Pages site. The cost is losing the deployment URL in the Actions
# UI sidebar.
on:
release:
types: [released]
Expand All @@ -33,9 +41,6 @@ jobs:
deploy:
if: github.event_name != 'workflow_run' || github.event.workflow_run.conclusion == 'success'
runs-on: ubuntu-latest
environment:
name: github-pages
url: ${{ steps.deployment.outputs.page_url }}
steps:
- uses: actions/checkout@v4

Expand Down