Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 69 additions & 0 deletions .github/workflows/side24-v1-coefficient-review.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
name: SIDE24 v1 coefficient nonauthor review checks

'on':
pull_request:
paths:
- 'reviews/side24_v1_coefficient_claude_20260929/**'
- '.github/workflows/side24-v1-coefficient-review.yml'
workflow_dispatch:

permissions:
contents: read

jobs:
exact-and-probe:
runs-on: ubuntu-latest
timeout-minutes: 10
steps:
- uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262
with:
persist-credentials: false
- uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065
with:
python-version: '3.11.16'
- name: Verify sources, replay both modes, reject mutants, replay the reviewed package
env:
PYTHONDONTWRITEBYTECODE: '1'
run: |
set -euo pipefail
python -B -S - <<'PY'
import hashlib, json, pathlib, subprocess, sys
root = pathlib.Path('reviews/side24_v1_coefficient_claude_20260929').resolve()
manifest = json.loads((root / 'SOURCE_FILES.json').read_text())
present = sorted(p.name for p in root.iterdir())
expected_names = sorted([e['path'] for e in manifest['files']] + ['SOURCE_FILES.json'])
if present != expected_names:
raise ValueError('packet tree differs from manifest: ' + repr(present))
for entry in manifest['files']:
path = root / entry['path']
if pathlib.PurePosixPath(entry['path']).name != entry['path'] or path.is_symlink():
raise ValueError('flat regular source required: ' + entry['path'])
data = path.read_bytes()
if len(data) != entry['bytes'] or hashlib.sha256(data).hexdigest() != entry['sha256']:
raise ValueError('source identity mismatch: ' + entry['path'])
# the reviewed package must be the bytes the verdict binds to
for entry in manifest['reviewed_object']['paths']:
data = pathlib.Path(entry['path']).read_bytes()
if len(data) != entry['bytes'] or hashlib.sha256(data).hexdigest() != entry['sha256']:
raise ValueError('reviewed object drifted: ' + entry['path'])
script = str(root / 'coefficient_review_check.py')
expected = (root / 'RESULTS.json').read_bytes()
mutants = ['M1', 'M2', 'M3']
for flags in (['-B', '-S'], ['-B', '-O', '-S']):
out = subprocess.run([sys.executable, *flags, script],
check=True, capture_output=True, timeout=300).stdout
if out != expected:
raise RuntimeError('output differs from RESULTS.json under ' + ' '.join(flags))
for m in mutants:
rc = subprocess.run([sys.executable, *flags, script, '--mutant', m],
capture_output=True, timeout=300).returncode
if rc != 1:
raise RuntimeError('mutant ' + m + ' not rejected')
# reproduction claimed in REVIEW.md item 7: package stdout == ENCLOSURE.json
pkg = subprocess.run([sys.executable, *flags, 'coefficients/side24_v1/coefficient.py'],
check=True, capture_output=True, timeout=300).stdout
if pkg != pathlib.Path('coefficients/side24_v1/ENCLOSURE.json').read_bytes():
raise RuntimeError('coefficient.py output differs from ENCLOSURE.json under ' + ' '.join(flags))
print(json.dumps({'scientific_effect': 'NONE', 'mathematical_acceptance': False}))
PY
git diff --exit-code
38 changes: 38 additions & 0 deletions reviews/side24_v1_coefficient_claude_20260929/RESULTS.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
{
"object": "CL-SIDE24-V1-REVIEW-20260929-v1-CHECKS",
"passed": true,
"results": {
"R1_hermite_sums": {
"0": 1,
"1": 1,
"2": 2,
"3": 4,
"4": 10,
"5": 26,
"6": 76
},
"R2_lattice": "shell count 24j^2+2 <= 27j^3; |n|^6 <= 27 j^6; term ratio <= 512 e^-864 < 1/2 -> sum <= 1458 e^-288",
"R3_image_ledger": {
"32eps": "<1e-106",
"60E": "<1e-108",
"E": "21175738586478e-125"
},
"R4_covariance_floor": "Hessian block eigen {5, 2,2,2,2,2}; odd block min eigen 8-sqrt(58)=0.384 > 1/3; gradients 1 -> C_ref >= I/3",
"R5_density_comparison": "a=m+2/3+n/2, b=d+n/2 (<=5 for d=2,3); (1+eps)^5/(1-eps)^5 <= 1+32eps exactly at eps=1e-108",
"R6_cone_moments": {
"D_1": "4/3",
"D_2": "29/6 - sqrt(6)",
"untruncated_half": "29/6 (control)"
},
"R7_closed_form": {
"c2_decimal_60": "0.073406919306034271030135962957774050017664244684332671851381",
"c2_float": "0.073406919306034296",
"c3_decimal_60": "0.041775931840598343342936665428575556466681519661044737884976",
"c3_float": "0.041775931840598357",
"gamma_7_6_decimal_60": "0.927719333630039200708349482534621018566466519145475576936124",
"independent_45_digit": "0.0417759318405983433429366654285755564666815197 (clean-context re-derivation, 2026-09-29; matched to 1e-45)"
},
"R8_stirling": "B_2..B_22 exact; first omitted term positive (DLMF 5.11(ii) sign)"
},
"scope": "finite identities of the coefficient note and its program; by-hand items in REVIEW.md"
}
Loading
Loading