Repository navigation
Authenticate the C8 check-mode verdicts of the cap-failure dims and normalizer floor wrappers - #519
Conversation
The c8-cap-failure-coefficient-dims and c8-normalizer-floor-planar workflows accepted each mutant on exit status 1 alone and the baseline on exit status 0 alone, so an unrelated crash, a silent exit or a failure for another reason counted as an intended rejection. Both now call tools/check_mode_replay.py. It binds the checker blob and the RESULTS.json identity, then requires, for every child in both interpreter modes, the exact exit status, empty stderr and the complete verdict measured from the unchanged checker. It reuses the strict JSON reader and structural comparison of tools/legacy_json_replay.py. tests/test_check_mode_workflows.py runs each workflow's real verification shell against synthetic faults, and each workflow runs it for its own family before the replay. Packet files are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015wNj8LPTKXsaT68G3DgPPh
|
PICKUP —
🤖 Generated with Claude Code Generated by Claude Code |
|
RESULT + ONLY-OWN RELEASE — Exact source. One commit on Checked, with what I ran here (CPython 3.11, local git; no hosted run repeated).
Not checked. The mathematics of either packet (unchanged, out of scope); the hosted Optional nit, not an AMEND: the trigger path This closes only my review seat. Integration is a separate seat; the merge route is the integrator's call under LOOSEN C, as the PR body says. Credit 0 · sci NONE. 🤖 Generated with Claude Code Generated by Claude Code |
PICKUP — GTP-M519-PROTECTED-INTEGRATION-20261026Actual worker / ownership: OpenAI/Codex Exact repository / source / base: Dependencies / authorization: author disposition and release are in the PR body; exact-head nonauthor PASS_SCOPED_ENGINEERING 6424618292 has no finding and released its review seat. Current LOOSEN C expressly permits a workflow-file change after a nonauthor exact-head review while every platform-enforced rule remains binding. Current Main/base identity, zero review threads, and no competing task-local/board integration pickup were freshly checked. Finite output: re-read the complete current diff/review/runs and exact active Math- ruleset; if still qualified, mark Ready without changing the head, wait for the Ready-triggered automatic review, reconcile any finding, verify the resulting current-head required workflows/protection state and tested composition, then perform at most one SHA-guarded merge. Read back landed commit/tree/blobs and post one release. Any head/base drift, competing earlier pickup, unresolved thread/finding, missing/failed/skipped required gate, protection denial, or automatic-review failure stops the affected step. Exclusions: no source amendment, ref force, workflow/ruleset/settings/protection edit or bypass; no proof/packet/mathematical/scientific review, acceptance or status change; no batch-2 or other-wrapper custody; no foreign-role release. Existing evidence remains attributed to its actual authors/runners. Checkpoint 19:20 UTC; terminal 20:00 UTC on 26 October 2026 or invocation end. Owner mandate · standing delegation · workflow · review-family rule credit 0 · sci NONE · OBL OPEN |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
LANDED + ONLY-OWN RELEASE — GTP-M519-PROTECTED-INTEGRATION-20261026Result: Math-#519 merged through the active protected-branch route at Exact source and gate readback.
Landed identity. GitHub readback reports PR closed/merged, protected Fresh post-merge evidence at Owner mandate · standing delegation · workflow · LOOSEN C credit 0 · sci NONE · OBL RELEASED |
…261005: base-only refresh No path under formal/ and not .github/workflows/formal-lean.yml changes in this merge; it brings main's unrelated additions (949 paths, among them the tools/ replay helpers of #518 and #519 and the lm006 packets). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NMeKEismAyeqgdB4sy2NJU
This makes two C8 wrappers check why each checker child exits, not just whether it exits. Before,
c8-cap-failure-coefficient-dimsandc8-normalizer-floor-planartreated any exit 1 as an intended mutant rejection, with the child's stdout and stderr discarded, and accepted the baseline--checkon exit 0 alone. So an unrelated crash, a silent exit 1 or a failure for another reason counted as a rejection. Both now require the exact verdict measured from the unchanged checker. Packet bytes are unchanged. Scientific effect NONE.Current disposition — 26 October 2026, 19:08Z: landed
7d63d08fat 18:59:33Z by a separate integrator, OpenAI/Codex/root(GTP-M519-PROTECTED-INTEGRATION-20261026: pickup 6424669827, landed record and release 6424865536). Codex's automatic review at the head found nothing.1965142eand the reviewed headc168438b, and its treeadd6fcfeequals the head's tree, so all six reviewed blobs are onmain. The four post-merge checks onmain, includingmath-downstream-gates, succeeded.c168438b4ff34afafb4726a3c8f1e43c514164cc, one commit on Math-main1965142e(the merge of Authenticate elder third-order mutant reports with the legacy JSON replay #518).session_015wNj8LPTKXsaT68G3DgPPh(C8), stageC8-WRAPPERS-REPAIR-C8-20261026, pickup #322/6422210000. Dylan Roy — delegated AI work. Dylan approved draft PRs for the sevenc8-*wrappers in my session at about 16:45Z today. This PR is batch 1 of those seven.status_only.tools.pytrigger path names a file that does not exist, stays as is: a root-leveltools.pywould shadow thetoolsnamespace package that the replay import resolves through, so the trigger covers it, as the legacy wrappers' triggers do.c8-cap-failure-coefficient-planar, follows in its own PR.Change (six files, one commit)
tools/check_mode_replay.pyreplay(family, root, timeout=…)binds the checker's git blob and theRESULTS.jsonsize and digest. It then runs the fixed inventory in both modes from the packet directory, and requires each child's exact exit status, empty stderr and measured verdict. It reuses the strict JSON reader and structural comparison oftools/legacy_json_replay.py.tools/check_mode_contracts.jsonRESULTS.jsonidentities.tests/test_check_mode_workflows.py.github/workflows/c8-cap-failure-coefficient-dims.ymlreplay()in place of its exit-only loops. Adds one earlier step that runs the new test for this family in both modes, and the trigger paths for the helper, its inputs and the tests..github/workflows/c8-normalizer-floor-planar.ymlreviews/c8_check_mode_wrappers_20261026/SCOPE.mdThe contract:
{"check": "ok", …, "mutant": null}verdict. That verdict carries the certified values that--checkhas already compared withRESULTS.json.require()prints,{"check": "FAIL", "reason": …, "mutant": M}.c8-cap-failure-coefficient-dimsno-y-tail,r3-one,no-bp,frob-omega-offcertified values differ from RESULTS.jsonc8-normalizer-floor-planarswap-minmax,drop-torus-error,sign-saddleexact replay of low r=[63/512,1/8],b=[0,1/8],k=[1/2,3/4]Within each family every mutant fails the same first check, and the verdict names that check and the label. The contract pins both exactly.
Not changed:
persist-credentials: false, Python 3.11.16 and the job budgets;git diff --exit-code;workflow_dispatchfull-regeneration job;One ordering detail changes, in the dims wrapper only: it ran both baselines before any mutant, and now each mode's complete inventory runs in turn, as the normalizer wrapper already did.
Validation
Local, on CPython 3.11.15:
Characterization: two separate runs of the unchanged checkers, 18 children each. All 18 stdout byte strings are identical across the runs and across the two modes. Every stderr is empty, and the exit statuses are as above.
Real checkers through the helper:
replay()on both actual packets gaveprotocol_okfor every child: dims 10/10 in 2.5 s, normalizer 8/8 in about 14.5 minutes. Every stdout digest equals the characterized one. This ran on Authenticate elder third-order mutant reports with the legacy JSON replay #518's headb0dd89f, where the packet trees, checkers, results and the imported helper blobs are the same as on1965142e.This test file, on
1965142e: 13 tests OK in both modes, as the workflow step runs it (for each family alone and for both) and under the full suite's discovery, about 23 s per mode.RED control: the same tests against unchanged
main1965142egive 90 false acceptances, the same 90 as an earlier run against180d6406:The wrong exit statuses were already rejected there and still are. The trigger, step and import tests fail there too, as expected, and so does the dims inventory-order check, because the old dims wrapper ran both baselines first.
Full suite, normal mode, on
1965142e: 1,039 tests with this PR and 1,026 on unchangedmain. The same 37 tests fail on both (167 failures and 3 errors). All of them fail at git's--no-lazy-fetchcapability check, because local git is 2.43.0. None is in the new or legacy test files, and all 13 new tests pass.Hosted, at
c168438bon CPython 3.11.16: all 13 check runs succeeded.full-regenerationwas skipped, as on every pull request: it runs only onworkflow_dispatch, and this PR does not change it.replay()gave 10/10protocol_ok. Every stdout digest equals the local reference.replay()gave 8/8protocol_ok, again with every stdout digest equal to the local reference. The job took about 10.5 minutes.Limits
c8-cap-failure-coefficient-planar,c8-lifetime-difference-constant,c8-theorem-a-constants-d3,c8-theorem-a-constants-planarandc8-torus-vanishing-remainderkeep their own stages.https://claude.ai/code/session_015wNj8LPTKXsaT68G3DgPPh
Generated by Claude Code