Skip to content

Test missing-manifest dispatcher behavior without skipping - #238

Merged
d6g8k5htny-coder merged 1 commit into
claude/drive-audit-github-migration-rrglppfrom
codex/test-dispatcher-missing-manifest-20261002
Oct 2, 2026
Merged

d6g8k5htny-coder merged 1 commit into
claude/drive-audit-github-migration-rrglppfrom
codex/test-dispatcher-missing-manifest-20261002

Conversation

@d6g8k5htny-coder

Copy link
Copy Markdown
Owner

Scope

Replace the ambient-repository skip in test_dispatcher_reports_unbound_inputs_when_the_manifest_is_absent with a deterministic temporary-file CLI fixture. Only tests/test_lanes.py changes.

The fixture supplies explicit lanes, graph, absent MANIFEST and present BINDING paths. It covers:

  • Empty inputs, preserving the documented manifest-free input contract
  • A declared member input that is intentionally checker-invalid without MANIFEST; the dispatcher must retain that declaration and report it unbound even when BINDING lists it
  • The exact missing-manifest diagnostic, without changing any real index

Existing checker refusal for declared inputs without MANIFEST was already tested. This repair adds deterministic dispatcher coverage; it does not change production behavior, lane validity rules, source bytes, manifests, scientific claims or statuses.

Base and isolation

Targets claude/drive-audit-github-migration-rrglpp, after #237, at cb426bf9166d2a22980290fffdfb1182e9173154. It does not target the default main branch.
Published head: c84a1573342cb574eac7737c69d66f3b180b6ee4.
Candidate tree: 053a91d27eee5bf67c100fd72aea0ffa0e3604ba.

The two PR237 repair owners confirmed this one-file scope is disjoint. Full remote file readback matches the locally reviewed and tested candidate exactly.

Verification

  • Python 3.11.16: all 54 lane tests pass, with no skips
  • PYTHONOPTIMIZE=1: all 54 lane tests pass, with no skips; pytest emits its standard optimized-assertion warning
  • Disposable bound=True and erased-input mutants each fail the intended assertion in normal and optimized modes; unmodified production passes both
  • Repository precommit checks and lanes_check pass with existing documented findings preserved
  • Nonauthor technical review found no blocking issues and independently passed the focused test in both modes; same-provider review earns zero organizational-independence credit

The unchanged base tree's recorded full suite was 2128 passed and 1 skipped. A changed-tree local full-suite run was canceled before completion and is not claimed as passed. Fresh hosted full CI on this exact new head is required.

Keep this PR draft until #237's landed verification is confirmed, this exact head has fresh review and hosted CI passes, and the current migration base is rechecked. A green run is an engineering check, not mathematical acceptance.

@d6g8k5htny-coder d6g8k5htny-coder left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nonauthor engineering review of exact head c84a157: no blocking findings in this narrow test-only repair.

Independently verified through published commit metadata, the PR diff, full file readback, and local execution:

  • Sole parent: cb426bf. Exactly one changed file: tests/test_lanes.py (+31/-6).
  • Published file bytes exactly match the reviewed and executed local file, blob d3facec6cbe1981380373dca80b724a47cf9fba2. The local tested tree matches published tree 053a91d27eee5bf67c100fd72aea0ffa0e3604ba. The local base has different commit ancestry but the identical parent tree 2dd8520408f8bc6305f566b30b55865cb98afaf0.
  • Python 3.11.16: all 54 tests in tests/test_lanes.py pass normally, with no skips; all 54 pass with PYTHONOPTIMIZE=1, with no skips and pytest's standard optimized-assertion warning.
  • git diff HEAD --check passes.

The replacement deterministically exercises the actual dispatcher CLI with isolated inputs and an absent manifest. It asserts the expected lane keys, preserves both empty and declared input lists, reports both lanes unbound, and pins the absent-manifest diagnostic even when the member binding index contains the declared input. The nonempty declaration remains intentionally checker-invalid without MANIFEST; this tests transparent diagnostic reporting and preserves the existing lane-validity contract. No production behavior or real index is changed.

Limits: this review does not establish a completed full-suite run on the changed tree. Hosted full CI and merge remain separate gates. This same-provider technical review earns zero organizational-independence credit; independence-requiring gates remain open. It establishes no scientific acceptance, mathematical claim, premise discharge, or status promotion.

@d6g8k5htny-coder
d6g8k5htny-coder marked this pull request as ready for review October 2, 2026 19:47
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-02T19:50:01.839730Z c84a157 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@d6g8k5htny-coder
d6g8k5htny-coder merged commit b6ccb5e into claude/drive-audit-github-migration-rrglpp Oct 2, 2026
2 checks passed
@d6g8k5htny-coder
d6g8k5htny-coder deleted the codex/test-dispatcher-missing-manifest-20261002 branch October 2, 2026 19:49

Copy link
Copy Markdown
Owner Author

Landed verification for this test-only repair is complete.

  • Merged only into claude/drive-audit-github-migration-rrglpp as b6ccb5e2363dfe859973bf960c494c65488b8bc2; its tree 053a91d27eee5bf67c100fd72aea0ffa0e3604ba matches the reviewed/tested candidate exactly
  • Landed CI: all steps successful; 2129 tests passed in 413.77s, with no pytest skips
  • Exact-head nonauthor review: no blocking findings; 54 lane tests pass normally and optimized; both deliberate bad-reporting mutants were rejected in both modes
  • Only tests/test_lanes.py changed. Landed dispatcher, MANIFEST and BINDING blobs match their pre-change identities

The formerly skipped missing-manifest scenario now runs with isolated temporary inputs. Empty inputs retain their documented contract; an invalid declared input remains visible and unbound. This is test coverage and engineering verification, with zero organizational-independence credit and no scientific acceptance or status change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant