Repository navigation
The quarantine summary counted twenty-two comparisons where sixteen ran - #50
Merged
d6g8k5htny-coder merged 2 commits intoSep 24, 2026
Conversation
Invariant 3 of `tools/quarantine_check.py` is "no excluded payload digest
appears in any repository manifest". It can only ask that of a record carrying
a `payload_sha256`. Six of the twenty-two exclusions do not carry one, so the
loop skipped them in silence while the summary line printed `exclusions=22`.
A reader auditing quarantine coverage off that line counted twenty-two checks
where sixteen had been performed.
This is an accounting fix. The same sixteen digests are compared as before,
and nothing here compares more.
Widening the invariant to all twenty-two would be wrong rather than merely
awkward. `Q-R17-DUP-001` is an EXACT_DUPLICATE whose digest does exist, in a
free-text `identity` field; an exact duplicate shares its bytes with a
*retained keeper* by definition, so promoting that digest into
`payload_sha256` would fire invariant 3 on the keeper and break the build on a
correct tree. Verified: the excluded surplus copy
(1Y_3zFonLsFIAHP5KSkUfsJXqHZXIUAL2) is tree-only DO_NOT_PORT with `sha256:
null`, and the one stored row carrying those bytes is the keeper, a different
Drive object (1Hc8dJvdh504xKBBHXswU5Ly-_8uYp_Sv) under the 2026-09-15 KIMI
FINAL INTAKE lane. Nothing excluded has leaked, and two controls read that off
the manifests rather than asserting it.
What the checker now does:
- counts and reports `digest_comparable=16 digest_not_compared=6`;
- refuses a record it cannot compare that does not say why, so a new
exclusion cannot join the unchecked set by omitting a field;
- refuses a run in which nothing was compared at all, the same vacuity floor
`verify_manifests.py` already carries;
- refuses a declared reason that has stopped being true -- one naming a key
that is not an exclusion, or one whose record has since gained a digest.
The reasons live in `DIGEST_NOT_COMPARED` in the checker rather than on the
records because `research/rn/candidates/inner_wedge_20260920_v1.json` pins
`quarantine/EXCLUSIONS.json` twice as source identity, at 19,555 bytes /
`8a5a8901...`; adding a field there fails four replay checkers closed. A label
is not worth breaking a pin for. A new exclusion still states its reason on the
record, in a `payload_digest_not_compared` field, and both routes are
controlled. Two further controls assert the pin itself and read the expected
digest back out of the certificate, so the next person to reach for that file
learns about the binding here instead of from a red CI run.
`tests/test_quarantine_digest_coverage.py` holds twenty-one controls, every one
invoking the checker through its CLI against synthetic or mutated inputs so a
path bound at import time cannot silently re-check the real repository. Nine
weakened copies of the checker were built in the scratchpad and run against
them -- reason requirement removed, whitespace accepted as a reason, vacuity
floor removed, the reason turned into an opt-out from the comparison, the leak
report silenced, the two counters swapped, each arm of the stale-table guard
removed, and the reason lookup short-circuited to always satisfied. Each was
caught, by the control written for it and by no other.
What this does not establish: nothing about any claim, premise, obligation,
gate or theorem. It moves no status and clears nothing. A pass says sixteen
excluded digests are absent from every manifest in this tree and that six
records are outside that comparison for stated reasons -- not that those six
are harmless, not that their contents were reviewed, and not that the
quarantine is complete.
Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Cz7WZybv8znP64SpPj6sWY
Keep the digest-coverage accounting on the checker, its tests, the CONSUMERS registration, and the README. Place the tip path-map section after that accounting. quarantine/EXCLUSIONS.json stays the tip pin. Co-authored-by: Dylan Roy <d6g8k5htny@privaterelay.appleid.com>
d6g8k5htny-coder
marked this pull request as ready for review
September 24, 2026 03:45
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
d6g8k5htny-coder
merged commit Sep 24, 2026
c82c935
into
chatgpt/drive-github-hardening-20260919
4 checks passed
Merged
10 of 15 tasks
This was referenced Oct 23, 2026
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
tools/quarantine_check.pynow reports how many exclusions invariant 3 actually compared, refuses a record it cannot compare that does not say why, and refuses a run in which it compared nothing.quarantine/README.mdrecords the split;registers/CONSUMERS.jsonrecords the new test as a machine consumer of thequarantine_indextab;tests/test_quarantine_digest_coverage.pyis new.quarantine/EXCLUSIONS.jsonis byte-identical to its parent commit — see Where the reasons live below.Type of change
quarantine/README.md, alongside the tooling)The defect
Invariant 3 is "no excluded payload digest appears in any repository manifest". It can only ask that of a record carrying a
payload_sha256. Six of the twenty-two exclusions do not carry one, so the loop skipped them in silence while the summary line printedexclusions=22. Anyone auditing quarantine coverage off that line counted twenty-two comparisons where sixteen had been made.This is an accounting fix. The same sixteen digests are compared as before; nothing here compares more.
Why not simply widen the invariant
Because it would be wrong, not merely awkward.
Q-R17-DUP-001is anEXACT_DUPLICATEwhose digest does exist, in a free-textidentityfield — and an exact duplicate shares its bytes with a retained keeper by definition. Promoting that digest intopayload_sha256would fire invariant 3 on the keeper and break the build on a correct tree.Verified 2026-09-24, read off the manifests rather than asserted:
1Y_3zFonLsFIAHP5KSkUfsJXqHZXIUAL2DO_NOT_PORT,stored: false,sha256: null1Hc8dJvdh504xKBBHXswU5Ly-_8uYp_SvNothing excluded has leaked, and two controls re-derive that from the manifests on every run.
The other five are three
EXISTING_CONTAINERfolder pointers (one of them the99_DO_NOT_OPENvault), a native Google document for which the corpus declares no payload digest, and aSUPERSEDEDrecord identified by byte count alone.What the checker now does
digest_comparableanddigest_not_comparedseparately;verify_manifests.pyalready carries;Where the reasons live, and why that is not where they belong
research/rn/candidates/inner_wedge_20260920_v1.jsonpinsquarantine/EXCLUSIONS.jsontwice as source identity, at 19,555 bytes /8a5a8901…. Adding a field there fails four replay checkers closed — found the way everyone else finds it, by doing it:A label is not worth breaking a pin for, so these six reasons are declared in
DIGEST_NOT_COMPAREDin the checker instead. A new exclusion still states its reason on the record, in apayload_digest_not_comparedfield; both routes satisfy the check and both are controlled.Two further controls assert the pin itself and read the expected digest back out of the certificate, so the constants and the binding cannot drift apart, and the next person to reach for that file learns about it here rather than from a red CI run. That discoverability gap is wider than this one file — twelve certificates pin thirty-eight paths between them and no document in the tree mentions them — and I would like to close it separately rather than widen this PR.
Status discipline
quarantine/EXCLUSIONS.jsonis byte-identical to its parent commitclaims/graph.jsonunchanged — no claim or premise status movedregisters/json/work_events.jsonunchanged — this is neither a claim nor a publicationIf this is a review
Not a review. No verdict is recorded and no independence credit arises.
Controls
tests/test_quarantine_digest_coverage.py— twenty-one controls, every one invoking the checker through its CLI against synthetic or mutated inputs, so a path bound at import time cannot silently re-check the real repository.Nine weakened copies of the checker were built in a scratchpad — never by editing the library — and run against the controls:
…must_say_why,…blank_reason…,…cannot_join_the_unchecked_set_silentlytest_a_blank_reason_is_not_a_reasontest_a_run_that_compared_nothing_is_refusedtest_a_reason_does_not_excuse_a_record_that_does_carry_a_digesttest_a_leaked_payload_is_still_caught…gained_a_digest_is_refused…that_is_gone_is_refusedEach was caught, by the control written for it and by no other.
Verification
Every step of
.github/workflows/ci.ymlwas replayed locally against this tree — all 44, including the mathematical replays and the complete pytest suite.What this does not establish
Nothing about any claim, premise, obligation, gate or theorem. A pass says sixteen excluded digests are absent from every manifest in this tree, and that six records sit outside that comparison for stated reasons — not that those six are harmless, not that their contents were reviewed, and not that the logical quarantine is complete. Counting what a checker skipped is not checking it.
Base
Targeted at
chatgpt/drive-github-hardening-20260919rather thanclaude/drive-audit-github-migration-rrglpp: PR #2 was merged and then reverted by #32, PR #3 is closedNEVER-MERGE, andmain's landing page names this branch as the active research line. The three substantive files were byte-identical on both branches when this was written.🤖 Generated with Claude Code
https://claude.ai/code/session_01Cz7WZybv8znP64SpPj6sWY
Generated by Claude Code