Skip to content

fix(cbz): block missing declared canonical inputs (R3) - #716

Merged
d6g8k5htny-coder merged 1 commit into
mainfrom
codex/cbz712-r3-canonical-input-01a11d37-20261029
Oct 31, 2026
Merged

d6g8k5htny-coder merged 1 commit into
mainfrom
codex/cbz712-r3-canonical-input-01a11d37-20261029

Conversation

@d6g8k5htny-coder

Copy link
Copy Markdown
Owner

A declared canonical registry can disappear while the crawler reports zero BLOCK findings and silently loses artifact coverage. This fixes R3 from the executed adversarial review of #712.

At the existing missing-entry branch, emit BLOCK INPUT-MISSING with the canonical label, repository, full selected ref and path. The real CLI then returns exit 1. Explicit historical refs remain authoritative: a registry present at its declared historical ref still verifies after its current path disappears. Never-declared optional discovery files retain their existing absence behavior.

This is a separate two-file contribution stacked against claude/nice-maxwell-7i7ok0-drift, based exactly on 15e8f689d00ca03e28e9bc5d97b6aba3f19ec900. Production adds three lines, including its diagnostic table entry. The focused test file retains the original R3 witness verbatim with provenance from 9a5d313b, plus selected-ref, positive, optional-discovery and real CLI controls. Original 43 tests and all original six adversarial cases are unchanged. Root owns composition and integration.

Observed local verification

CPython 3.9.6, macOS 15.7.4 arm64, exact candidate tree d6f8eb15af4216eb93352b96382264e5d39525cf.

Run Normal Optimized parent
Original 43 before repair 43 PASS, exit 0 43 PASS, exit 0
Focused nine before production edit Six intended assertion failures, three PASS, zero errors Same
Candidate focused nine 9 PASS, exit 0 9 PASS, exit 0
Candidate original 43 43 PASS, exit 0 43 PASS, exit 0
Unchanged original six with identical production overlay in separate qualification checkout R3 PASS; five assertion failures, zero errors, exit 1 Same

From tests/:

python3 -B -m unittest test_cbz_drift_canonical_input -v
python3 -B -O -m unittest test_cbz_drift_canonical_input -v
python3 -B -m unittest test_cbz_drift -v
python3 -B -O -m unittest test_cbz_drift -v

The focused CLI children inherit parent optimization. The unchanged original mutation harness still launches normal -B designated children, even under an optimized parent; optimized mutant-child coverage is not claimed. Its 35 designated assertion mutants and unmutated controls pass. Errors are never credited as kills.

The five crawler qualification residuals remain factual: advanced remote tips, child workspace graph closure, missing Lake revision, newly opened local Lake dependency scanning, and unheld reachable Lake dependency discovery. These are preserved in the original six-case suite.

Broader verification covered 15 workflow-reading modules: final corrected invocation ran 400 tests, with nine Atlas oracle subtest assertion failures and zero errors, exit 1. All nine reproduce on the unchanged exact base: six mutations (inventory, green, drift, overwrite, exit, error) in AtlasBrowserRunnerControls.test_six_runner_source_mutants_are_killed_by_assertions, and three bodies (failure, subtest, context) in OracleOriginControls.test_genuine_baseline_and_assertion_origins. Initial fixture/setup/invocation/temp-path failures and their corrections remain in the frozen local evidence.

Source and evidence identity

  • Production blob 123dfb6c8dfd50ecd529f6aa5f9d01f4a2290da6; SHA-256 27cee49ca1ccbc628f95a087e7ff1bf2149bf7d95ce12b5935f8e6ef91ed134e.
  • Focused-test blob df3fa09a8d7e044f0010abad4beeee8bca7fa558; SHA-256 4c9cc98dabe42d0acf527908cab6ab0395ee847f40051832951f79ce6313778e.
  • Frozen report: 9,977 bytes; SHA-256 7059ac840909138bdd28e7b872eb5596d231077ccd067032377f8296e7c5ccd8.
  • Full review diff: 7,932 bytes; SHA-256 d5b9d6390b657d0495e0ed2653e18b4f87192f2bba00d2ba34090fe14149228a.
  • Frozen evidence archive: 159,375 bytes; SHA-256 c285a460b2e84a6039a9991a6f16fb0f595c05eaeab761ec76f72e56c988d9c4. Evidence identifiers only; the archive is not added to this two-file PR.

Implemented by OpenAI Codex under owner delegation. Root reports fresh separate specification and quality review PASS on this exact tree; same-provider engineering review carries no scientific credit. GitHub API account attribution is retained; actual AI implementation provenance is in the commit message.

The existing #712 self-test invokes only test_cbz_drift; composition needs an explicit hosted invocation of the new focused module. This PR changes no workflow or canonical/math surface. Hosted success, full crawler qualification, G7 and CBZ-0 remain unclaimed.

Emit INPUT-MISSING with label/repository/selected-ref/path, preserving explicit historical input refs and optional discovery semantics. Add nine real-Git regression controls, retaining the original R3 witness with provenance.

Implemented by OpenAI Codex subagent cbz712_r3_registry_repair_20261029 under owner delegation. Engineering scope; scientific effect NONE. Original six qualification cases remain preserved; five unrelated defects remain open. No hosted success claimed.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-30T00:16:30.299143Z fe676eb PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copy link
Copy Markdown
Owner Author

FINITE EXACT-HEAD ENGINEERING REVIEW PICKUP — RLOOP-MAIN716-R3-MISSING-INPUT-REVIEW-20261030

Actual worker: OpenAI/Codex Research task loop /root, this invocation; nonauthor, nonintegrator, source-exposed same-provider engineering reviewer. Organizational, blind, mathematical, proof, and scientific-independence credit: 0; scientific effect NONE.

Exact candidate and finite scope:

  • Main fix(cbz): block missing declared canonical inputs (R3) #716 base/head/tree: 15e8f689d00ca03e28e9bc5d97b6aba3f19ec900 / fe676eb157dcbbeb6d8e461bd7dedc61096101fa / d6f8eb15af4216eb93352b96382264e5d39525cf.
  • Complete two-path delta: tools/cbz_drift/crawl.py and tests/test_cbz_drift_canonical_input.py.
  • Review only the R3 contract that a declared canonical input absent at its selected ref yields one identity-bound BLOCK INPUT-MISSING and CLI exit 1, while present historical refs and never-declared optional discovery remain valid.
  • Inspect exact patch/source identities and failure boundaries; independently run the focused and original crawler test modules in normal and optimized modes from candidate-bound bytes if materialization succeeds; observe current natural workflows; publish one COMMENT review or exact blocker; release.
  • Preserve the five explicitly unresolved crawler qualification residuals and the existing optimized-mutant-child limitation. The repository’s automated Codex review is acknowledged but supplies no manual/organizational-independence credit.

Explicit exclusions: no source/ref/branch/PR-body/label/Ready/workflow/rerun/protection/integration/merge/canonical/status/scientific mutation; no Lean theorem, mathematical validity, whole-federation G7, final G0–G11, or CBZ-0 completion claim. Stops: head/base drift, competing equivalent manual review or integration pickup, source/test mismatch, unverifiable evidence, platform denial, or 2026-10-30 01:00 UTC.

Authority/routing acknowledged: current CBZ governance, owner team directive, workflow, owner mandate, standing delegation. Canonical coordination remains #684 with general mirror #619; historical #475/#275 are not pickup threads.

@d6g8k5htny-coder d6g8k5htny-coder left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PASS_SCOPED_ENGINEERING_R3 — exact candidate fe676eb157dcbbeb6d8e461bd7dedc61096101fa over base 15e8f689d00ca03e28e9bc5d97b6aba3f19ec900; two-path tree d6f8eb15af4216eb93352b96382264e5d39525cf.

Manual source-exposed, same-provider, nonauthor engineering review only. Organizational/blind/mathematical/proof/scientific-independence credit: 0; scientific effect NONE.

Findings: none within the finite R3 contract. The change fails closed at the existing selected-ref lookup: a declared canonical input with no entry now emits one identity-bound BLOCK INPUT-MISSING before continuing, so the real CLI returns 1. The focused controls also preserve explicit historical-ref authority, verify present historical input after tip disappearance, and leave never-declared optional discovery absent without a block. I found no path/ref rebinding or loss of repository/ref/path/label identity in this delta.

Independent exact-byte evidence:

  • Candidate blob identities reproduced exactly: production 123dfb6c8dfd50ecd529f6aa5f9d01f4a2290da6 / SHA-256 27cee49ca1ccbc628f95a087e7ff1bf2149bf7d95ce12b5935f8e6ef91ed134e; focused test df3fa09a8d7e044f0010abad4beeee8bca7fa558 / SHA-256 4c9cc98dabe42d0acf527908cab6ab0395ee847f40051832951f79ce6313778e.
  • Focused module: 9/9 PASS normal; 9/9 PASS optimized.
  • Original crawler module: 43/43 PASS normal; 43/43 PASS optimized.
  • Natural exact-head workflows succeeded: CBZ federation drift run 40978224901 and research navigation run 40978224833.
  • Downloaded navigation artifact research-navigation-40978224833 matched recorded ZIP SHA-256 04699741c065f03ac4302103242861479b3bd59060c2326c56a0d6b872d0d5ce; its tests-normal.log shows the new R3 witness passing inside Ran 1729 tests in 433.978s, ending OK (skipped=37).

Limits preserved: this is not a claim for the five residual crawler qualifications (advanced remote tips, child-workspace graph closure, missing Lake revision, newly opened local dependency scan, unheld reachable-dependency discovery); optimized mutant-child execution remains unproved by the existing mutation harness. No Lean theorem, mathematical validity, whole-federation G7, final G0–G11, CBZ-0, integration, merge, or status-promotion conclusion follows.

Authority/routing: owner team directive, workflow, owner mandate, standing delegation.

Copy link
Copy Markdown
Owner Author

FINITE REVIEW RELEASE — RLOOP-MAIN716-R3-MISSING-INPUT-REVIEW-20261030

Released task-local manual engineering-review custody for exact base/head/tree 15e8f689d00ca03e28e9bc5d97b6aba3f19ec900 / fe676eb157dcbbeb6d8e461bd7dedc61096101fa / d6f8eb15af4216eb93352b96382264e5d39525cf.

Recorded COMMENT review PASS_SCOPED_ENGINEERING_R3: no findings within the finite R3 contract. Exact candidate bytes reproduced the claimed blob and SHA-256 identities; focused 9/9 passed in normal and optimized modes; original 43/43 passed in normal and optimized modes. The two natural exact-head workflows succeeded. The downloaded navigation artifact matched recorded SHA-256 04699741c065f03ac4302103242861479b3bd59060c2326c56a0d6b872d0d5ce and shows the new R3 test passing inside the 1,729-test suite, ending OK (skipped=37).

Limits remain exactly as reviewed: five crawler qualification residuals are open; optimized mutant-child execution is unproved; no mathematical/proof/scientific-independence, whole-federation G7, final G0–G11, CBZ-0, integration, merge, or status-promotion credit. Scientific effect NONE.

No source/ref/branch/PR/workflow/protection/integration mutation was performed. Root retains composition/integration custody; this reviewer is now unassigned from #716. Authority remains the owner team directive, workflow, owner mandate, and standing delegation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant