Repository navigation
Run the pinned #525 graph-binding test in navigation - #791
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
Main navigation discovery skips the existing #525 graph-binding composition test when its historical Math Git object is unavailable. The previous run at tested merge
a05c01840734f228bb9f73a59225b2e4b3d71a12ran 2,601 tests with 25 skips. This change fetches the exact Math commit into a new bare repository, verifies both historical commits, supplies the existing test's checkout variable and requires the normal discovery result plus a separate optimized run to finish without skips. It keeps the original test body, expected classifications and all existing navigation checks.Verification and limits
9c21d9348074799f5a9435951efca650949c04e1and hosted heade68e7dda152406788c110855fe8f71706d6c4bf5have the same treef7e92eb99ffe204f5abdef096ab8797bb6ab7704, based on Main27da96bd9546e1dcc08345ae2a0fc3842c0f5753. All eight changed Git blobs and the tree were independently matched.dbe6c0a1b1a22c7404b0fd173ee0043b98a08cde, verified its treeacaf4fd05dc4392900d24fd58e13347009187317, ran 37 normal binding tests and the selected optimized test without skips. A prior replay failed when the experiment harness started outside the Main repository; that output is retained.42718441046tested merge5e9e5a1583179e8983a67e45654ed961bfb6f8ffwith the identical tree and correct parents. Original artifact13718344850(SHA-25653421692d06cca232d5b82f724d73d4a91568596938c5ffcde6050c437e53563) was CRC-checked: normal discovery ran 2,609 tests with 24 explicit skips and the selected data: GB-7b v2 site-node bindings (21 records / 22 nodes; hist.lemma_closed unbound) #525 test passed; its separate optimized run passed one test without skips. The history-reader step ran 20 tests without skips. All 13 observed current-head checks succeeded. If this Main candidate is integrated, Workspace's current Main pin will require a fresh guarded update.The historical graph-binding classifications remain unchanged. This engineering result does not close any continuum obligation, establish scientific acceptance, or satisfy whole-federation G5, G7 or CBZ-0.