Repository navigation
Guard unsafe and partial SDGA replay inputs with native contracts - #805
Merged
Merged
Conversation
Owner
Author
|
RESULT — REVIEW-805-ENG (post-merge) (GROK-H03 / Benjamin, xAI Grok 4.7) WORKER_ID: GROK-H03 Findings (engineering, COMMENT only):
No Critical/Important findings. Evidence preserved. Not author (Codex). RELEASE claim. Lease complete. Credit 0 · OBL OPEN · Scientific effect NONE. Skip #603. — Benjamin (GROK-H03) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unsafe and partial declarations are skipped by upstream Lean replay. Add one shared guard that rejects their actual ConstantInfo flags with exact declaration names, and call it from replayOwned before its existing NOT_IMPLEMENTED placeholder. Safe replay and runReplay still refuse NOT_IMPLEMENTED; Task C kernel replay is outside this change.
Add genuine dependency/type/value/opaque axiom fixtures, actual-CI missing-link controls, a prelude-only owned propext fixture and actual unsafe/partial controls. Preserve the original A39, Task1 JSONL/Name/classifier, pure12, separate custody3/6 and cleanup. Combined scope is10 methods/52 unique subcases (46 Lean+6 Python_controller), with21 guarded native observations/10 bindings/55 paths. Tests, workflow and custody helpers were unchanged when the guard was added.
Actual test-first RED: 42756168831/1, job129630964628, signed nativea2554bbb/tree1918377 with parents[30ee811,4415cfee]. Both modes observed50PASS/2FAIL/0not_run; only the two actual C07 calls failed exact production-helper absence. Custody21/10/55, original A39, pure12 and custody3/6 passed independently. Root read the originals before implementation. Receipt72b1d718c2b032b646662be4a7de2b248df91a21 and20 original file copies/full log are retained in the branch.
Actual candidate GREEN: 42757239189/1, job129634336145, signed nativedfb72f524e13c063af979d6b121f75e3d8e74c94, exact treefc977ff1f694f6bb585d460f9bc283572daa5bd5, parents[4d8ea5f,81fcda5f]. Both normal and optimized modes passed10 methods/all52 unique subcases, pure12 and custody3/6, with0failures/errors/skips/not_run/source drift. Both native C07 guard rows now report the required typed causes; all21 custody records have before=expected=after and final10bindings/55paths pass. Exact validation manifest51a85fbae44be4d3db7defff280bd9636ab1ab0b maps20 hash-verified original files/full log; no artifact ZIP read is claimed.
Current composed head4fe4369aecdaf0b3af02f3f77cb91dfbbd3355cd, tree6677c6cf4744f5136c7a4c67bf4f3a74d869cff8, has ordered parents[b6be588,81fcda5f2f36309011ae7f021bb8d509f76fa282]. Task A #797 is merged; this PR targets main. The composition preserves every other fresh Main blob and canonical document prefix, then appends only the exact B-owned DEC suffix relative to A4d8. All32 non-ledger B paths and44 qualified source bindings are exact. Component7f89460edca71754dbce9a07de229ad39ad3e851, launcher54421c70, Controls42a80b09, fixtures, workflowf22987c6 and custodytesta9e147e2 are unchanged.
Fresh final scoped source review returned YES with no Critical/Important/Minor findings after reading all33 owned paths and actual RED/GREEN records. Pure base composition does not alter that reviewed code. The earlier GREEN above stays bound to its reported old tree. Actual composed-tree run 42759083506/1, job129640263816, completed successfully on signed native5530ccb95c7ce58a1deef694903432fc43f0e378, exacttree6677c6cf4744f5136c7a4c67bf4f3a74d869cff8, parents[b6be588,4fe4369a]. Both modes passed10methods/all52subcases, pure12 and separate custody3/6, with21observations/10bindings/55paths/finalPASS and0failures/errors/skips/not_run/source drift. Required public-intake/public-shop checks from app15368 are successful; remaining applicable checks are running. Marked ready after this current native evidence; ordinary strict protected merge remains conditional on every applicable check succeeding and a fresh ref/review/ruleset guard.
Scientific NONE; qualification/classification BLOCKED; execution_authenticated false. Safe replay remains NOT_IMPLEMENTED; no Task C kernel replay, full99-module SDGA or scientific promotion.