Repository navigation
ci: sanity checkout fetch-depth 2 so parent-pin tests can resolve HEAD^ - #157
Conversation
Co-authored-by: Dylan Roy <d6g8k5htny@privaterelay.appleid.com>
|
Evidence (run ff72) — scientific effect NONE Full That single remaining failure is Against |
|
CI result for this branch (run 36350681045) — scientific effect NONE Four gate jobs green.
So the shallow-checkout error class is gone; what remains on |
…-ci-deduplicate-premerge-20260926 to re-run sanity Co-authored-by: Dylan Roy <d6g8k5htny@privaterelay.appleid.com>
Scientific effect: NONE. One-line CI checkout change; no scripts, registers, claims, premises, prizes or lemma state touched.
Why
sanityis red on everymainpush since Batch 832. The two failures on the latest completedmainrun (36350109239,b9a1475f) are:Both Batch 832/833 parent-pin tests call
git rev-parse HEAD^. Thesanityjob usesactions/checkout@v4with the defaultfetch-depth: 1, so the checkout has no parent commit and the tests error before reaching their assertions. The loop runs the suite locally against a full clone, so it does not see this.Change
.github/workflows/ci.yml,sanityjob only:fetch-depth: 2. The four gate jobs (portable-patches-on-main,path-c-applied-bundle-dry-apply,land-workflows-dry-run,research-stack-status-guard) are untouched, so this does not overlap #155's gate rewiring (#155 adds a step afterInstall pytest; this touches only the checkout step above it — clean merge).Evidence
tests/suite on this branch in a full-history clone: exactly one failure,test_batch833…attests/test_intent.py:72485(trial.tip_sha == repair.trial_tip_after, the loop's own pin, already advanced by Batch 834/835).test_batch832…passes (wasHEAD^error onmain);test_batch833…reaches its assertion and fails on the pin (f7db5940… != 78ebd3b0…); one unrelated timing flaketest_batch267_when_writable_dual_daemon_status_race(passes onmain, on Dropbox intake digest — Dylan shared math corpus pointers #149, and locally).What this does and does not fix
mainpushes,HEAD^now resolves, so the 832/833 tests reach their real assertions.pull_requestruns HEAD is the synthetic merge commit andHEAD^is the base tip, so parent-pin equality checks are still expected to differ on PR branches (as on Dropbox intake digest — Dylan shared math corpus pointers #149 run 36349927928); that is not a property of any PR's payload.