Add hashes to mismatches#14
Open
matankalina wants to merge 1 commit into
Open
Conversation
natitati4
reviewed
May 12, 2026
| title := fmt.Sprintf("syz-verifier errno mismatch: %s vs %s (%s)", | ||
| vrf.kernels[0].cfg.Name, vrf.kernels[i].cfg.Name, firstMismatchCall) | ||
| vrf.saveMismatchReport(title, reportBody.String()) | ||
| vrf.saveMismatchReport(title, reportBody.String(), hash.String(prog.Serialize())) |
There was a problem hiding this comment.
Didn't we want to hash the prefix of the program until the first errno mismatch?
Also, should we include or ignore the parameters of the syscalls? i.e hash just the names? because many programs are the exact same (and achieve the exact same coverage) except slightly different parameters.
Collaborator
Author
There was a problem hiding this comment.
I need to find for each mismatch the corresponding syz-prog in the corpus.db. In corpus.go code they use the same scheme for defining the prog hash which is the unique identifier of a program inside the corpus. So until we change the unique identifier of a program in the corpus to the new scheme - I need to stick with their implementation.
matankalina
force-pushed
the
mkalina/add_hashes_to_mismatch_report
branch
from
6b3528a to
0e7100f
Compare
Save the syz-prog serialized bytes in the mismatch report
matankalina
force-pushed
the
mkalina/add_hashes_to_mismatch_report
branch
from
d203b65 to
a577833
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before sending a pull request, please review Contribution Guidelines:
https://github.com/google/syzkaller/blob/master/docs/contributing.md