feat: align async STAC resolver with Python client - #11
Closed
Faolain wants to merge 1 commit into
Closed
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Collaborator
|
Closing this connector-authored draft so it can be recreated under the required 0xSwego identity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The JavaScript client was already asynchronous and already used the resolver internally, so Python event-loop pooling and explicit client cleanup do not apply. However, the resolver was not exported from the package root, catalog listing stopped after one page, and pagination did not have the request hardening added in dClimate/dclimate-client-py#16.
Impact
Consumers can resolve a CID directly through the public package API. Existing high-level loading behavior is unchanged. Resolver and listing pagination now have the same trust boundary and bounded-walk behavior as the Python client, adapted to the platform-owned
fetchtransport.Validation
npm run lint: passednpm run build: browser and Node builds passed