Open
Conversation
This makes columns like `voxel_n` (int_64) being downcasted to the smallest numerical dtype possible. With the data used in tests/integration/test_core_class.py::test_split_on, this column can be downcasted to int8, which is ply compatible.
Author
|
Was wondering if the downcast propagation should be done on a copy of the points dataframe instead of the points dataframe itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
.plyfiles were not written with "double" coordinates even though the xyz coordinates columns were in float64 format.I was dealing with ply files in geospatial context and required to save a
.plyfile. I hit this issue, so here is the PR.This seems to have been a pain for the community:
Proposed changes
make float64 compatible with ply files (written ply files with float64 (double) coordinates can be opened by cloudcompare)
make property_format mapping better (written ply files can now exploit all the scalar data types a .ply file can support)

try downcasting column if column dtype is not compatible with PLY specification
fix most of flake8 issues (1 remaining)
backward compatible with Add support for
booltype in PLY files #309References :