Add unit tests for the date/spreadsheet helpers and wire up CI - #17
Closed
devin-ai-integration[bot] wants to merge 1 commit into
Closed
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Nader Dabit <dabit3@gmail.com>
dabit3
self-requested a review
July 28, 2026 23:32
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The pure helpers in
lib/(event date math, CSV parsing, email/code extraction) had no coverage, and nothing ran on PRs. This adds Vitest plus a GitHub Actions job so lint, typecheck, and tests all run on every pull request.Covered behavior worth calling out, since it's easy to regress:
daysUntilEventcompares calendar days, not elapsed time — both sides are normalized to local midnight, so a 3pmnowstill yields0for an event today and1for tomorrow. Tests pass an explicitnow(new Date(2026, 6, 17, 15, 30)) so they're deterministic, and one case spans a DST boundary where a naive(event - now) / 86400000would be off.eventCountdownLabelmaps0 → "Today",1 → "Tomorrow",n → "In n days", andnullonce past.extractCodesprefers a/^[\w\s]*codes?$/iheader column but keeps every row of a headerless single-column file.Runner is Node 22 in CI (Vitest 4 needs ≥20.19);
npm test=vitest run.Link to Devin session: https://app.devin.ai/sessions/a2b97d4e12ba4d19bedd24a6a58f237f
Requested by: @dabit3