Repository navigation
feat: harbor records from live reads, behind VITE_RECORDS_ENABLED - #4
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
David chose her. Bram stays he.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Inside the signed-in account panel, a "Read the harbor records" button opens three records. Each line is built from live public RPC reads (fastnear, finality final):
nft_token), no keys (view_access_key_listreturns[]), and the shared code pinned by the harbor (global_contract_hash=get_config.pet_code_hash).tidebound_journey, "The harbor replayed your steps and agreed they bring Mochi home.", Shells held and spent.A failed read shows "couldn't be checked", never success.
Flag
VITE_RECORDS_ENABLED=true, signed in, with Mochi present.Verified locally
bun run test: 246 pass, including 11 records tests covering failed and garbled reads.cargo test --workspace: 123 pass.make build,make browser(Chromium and WebKit) andmake evidencepass.bun run test:records-browser: 6/6 in Chromium at 390×844 and 1440×900. These run on recorded live-shaped RPC answers, not live calls. They cover the keyboard path, 44px targets, no horizontal scroll, all reads failing, and hidden-when-off / signed-out / no-Mochi with zero reads.Not verified
Merge note
make judgePR both add a PROGRESS.md row, so whichever merges second needs a trivial rebase.Also in this PR