Skip to content

feat: harbor records from live reads, behind VITE_RECORDS_ENABLED - #4

Merged
dadadave80 merged 7 commits into
mainfrom
feat/harbor-records
Nov 13, 2026
Merged

dadadave80 merged 7 commits into
mainfrom
feat/harbor-records

Conversation

@dadadave80

@dadadave80 dadadave80 commented Nov 13, 2026 •

Copy link
Copy Markdown
Owner

What

Inside the signed-in account panel, a "Read the harbor records" button opens three records. Each line is built from live public RPC reads (fastnear, finality final):

  • Mochi's papers: pet account, keeper (root nft_token), no keys (view_access_key_list returns []), and the shared code pinned by the harbor (global_contract_hash = get_config.pet_code_hash).
  • The Register's key line: each key exactly as the chain lists it (today FullAccess), then the actions Familiar's signer prepares. It says plainly that the chain enforces only the key permission. No key is changed or claimed to be a function-call key.
  • The Tidekeeper's stamp: accepted claims from tidebound_journey, "The harbor replayed your steps and agreed they bring Mochi home.", Shells held and spent.
  • Admin disclosure: Root and Items still hold full-access admin keys on testnet.

A failed read shows "couldn't be checked", never success.

Flag

  • Renders only when VITE_RECORDS_ENABLED=true, signed in, with Mochi present.
  • The flag is unset in production, so production is unchanged after merge; the production build contains none of the records code.
  • To verify, turn the flag on in production only after checking the panel in a real signed-in session.

Verified locally

  • bun run test: 246 pass, including 11 records tests covering failed and garbled reads.
  • cargo test --workspace: 123 pass.
  • make build, make browser (Chromium and WebKit) and make evidence pass.
  • bun run test:records-browser: 6/6 in Chromium at 390×844 and 1440×900. These run on recorded live-shaped RPC answers, not live calls. They cover the keyboard path, 44px targets, no horizontal scroll, all reads failing, and hidden-when-off / signed-out / no-Mochi with zero reads.
  • The record builder was also run read-only against live testnet: no line came back unchecked.

Not verified

  • A real signed-in Privy session. PR previews have no account functions, so this can only be checked in production with the flag on.
  • WebKit or a phone for this panel.
  • The "Privy wallet" sentence comes from configuration plus a key match; RPC cannot prove custody.

Merge note

  • This PR and the make judge PR both add a PROGRESS.md row, so whichever merges second needs a trivial rebase.

Also in this PR

  • Mochi is "her" in three player-facing lines (David's call); Bram stays "he".

@vercel

vercel Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
familiar Ready Ready Preview Nov 13, 2026 10:50pm UTC

@dadadave80
dadadave80 merged commit 556f196 into main Nov 13, 2026
3 checks passed
@dadadave80
dadadave80 deleted the feat/harbor-records branch November 13, 2026 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant