Repository navigation
fix: pass the records flag through the production release build - #6
Merged
Merged
Conversation
The release build defines each VITE flag explicitly; VITE_RECORDS_ENABLED was missing, so production never included the harbor records even with the flag set. It now follows the sealed note: production only, with a Privy app, and only when exactly true.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The production release build (
scripts/build-release.ts+buildGameSite) defines everyimport.meta.env.VITE_*explicitly.VITE_RECORDS_ENABLEDwas missing there, so the harbor records stayed off in production even with the Vercel flag set.This passes the flag through the same way as
VITE_SEALED_NOTE_ENABLED: on only forVERCEL_ENV=production, a Privy app present, and the value exactly"true".Verified locally:
bun run testpasses; a production-style build compiles records on with the flagtrueand off without it.Not verified: records in a real signed-in production session. That is checked after merge.
feat/season-two-uicontains this commit too, so merge order doesn't matter.