Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft PR intentionally contains a RED contract test only, not production changes. Do not merge.
Scope: extend user-initiated public-video URLs beyond YouTube/Twitch/Dailymotion with yt-dlp metadata and best-quality download. Preserve specialized existing paths.
Contract tests: accept public HTTPS sample Vimeo, Reddit and TikTok entry URLs without guessing site-specific media IDs; reject credentials, ports, local/internal/IP-literal or non-HTTPS targets and supplied forged IDs.
Security gate before implementation: URL validation of only the initial page is insufficient. yt-dlp follows redirects and can request media playlists and secondary hosts. Need a verified enforceable network boundary or a specifically constrained and tested supported extractor policy before arbitrary-site handling is enabled. No blanket
<all_urls>host permission, cookie access, shell execution, or remote components. Production code remains unchanged; all release assets untouched.Do not merge until implementation and security tests are complete and CI green.