fix(gateway): update handshake protocol to v4 - #367
Open
LAIM69420 wants to merge 1 commit into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe WebSocket client and gateway RPC handshake protocol bounds were changed from version 3 to version 4. Client and server handshake tests now assert the updated protocol parameters. ChangesProtocol v4 handshake
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix gateway handshake compatibility with OpenClaw protocol v4
Closes #361.
What changed
Why
Current OpenClaw gateways require protocol 4. Nerve advertised only protocol 3 from both connection implementations, so the gateway closed the WebSocket with code 1002 before authentication completed.
Verification
npx vitest run src/hooks/useWebSocket.test.ts server/lib/gateway-rpc.test.ts— 37 passedgit diff --check— passedserver/routes/gateway.test.ts(node:child_processmock has no default export)Summary by CodeRabbit
Enhancements
Tests