Skip to content

HotelwebのEslint修正#62

Open
enomoto906 wants to merge 5 commits into
masterfrom
eslint-enomoto
Open

HotelwebのEslint修正#62
enomoto906 wants to merge 5 commits into
masterfrom
eslint-enomoto

Conversation

@enomoto906
Copy link
Copy Markdown
Collaborator

eslintの修正

@enomoto906 enomoto906 changed the title Map.jsのEslint修正 HotelwebのEslint修正 Feb 14, 2019
Comment thread src/Map.js Outdated
let start2 = 1;
const jalanKey = 'and16735d417c1';
let timeData = 0;
let array = [];
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arrayは何が格納されているのかわからない

Comment thread src/Map.js
lodgingSpotData = lodgingSpotData.filter((v1, i1, a1) => (a1.findIndex(v2 => (v1.HotelID === v2.HotelID)) === i1));
lodgingSpotData = lodgingSpotData.filter(
(v1, i1, a1) => (a1.findIndex(v2 => (v1.HotelID === v2.HotelID)) === i1),
);
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ついでにメソッドの共通かもしてしまうといいんじゃない

Comment thread src/Map.js
const {
lodgingFacilities, touristFacilities, isOpen, error,
} = this.state;
if (error.state) {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

エラー処理いいね

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants