Pass xrel/yrel if SDL relative mouse mode is enabled#283
Closed
oznogon wants to merge 1 commit into
Closed
Conversation
Add RenderChain and Renderable functions onRelativeMove() and onRelativeDrag() to pass raw SDL event delta values (mouse xrel/yrel, touch dx/dy) instead of translated positions. If SDL2 relative mouse mode is enabled, pass deltas through these new functions, instead of passing positions through onPointerDrag and onPointerMove.
Owner
|
First off, I'm fine with this implementation. But I did check what I did in SP2 with for another experimental project. And there I actually send off the relative mouse movements to the keybinding system. Giving the advantage that you could bind other things (like joysticks) to this action as well. Might be something to consider? As I said, I'm also fine with this implementation, just thinking out loud here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add RenderChain and Renderable functions
onRelativeMove()andonRelativeDrag()to pass raw SDL event delta values (mouse xrel/yrel, touch dx/dy) instead of translated positions.If SDL2 relative mouse mode is enabled, pass deltas through these new functions, instead of passing positions through onPointerDrag and onPointerMove.
Follow-up to the weird abuse of interfaces PR #282.