Improve down/up event handling of axes#285
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Axis bindings, including some buttons that report as axes, can emit negative values that Keybinding::setValue() handles inconsistently with regard to setting
down_eventandup_event. This can cause button presses or axis movements that should trigger events to fail only because they emit negative values (left/down stick movements, certain triggers or sliders that rest at 0 and report negative values in one direction).Movement axes arguably shouldn't trigger
down_/up_eventsat all, so ignore mouse and joystick movement axes, but not game controller axes, which are often pressure-sensitive buttons or triggers. For other axes, handle negative values when calculating whether they exceed the threshold to trigger the event.