Don't duplicate SDL_JOY... events on SDL_CONTROLLERs#305
Merged
daid merged 1 commit intoMar 19, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDL simultaneously reports two different device axes for each analog trigger on an Xbox controller:
HotkeyBinder logic picks up whichever one crosses the threshold first, which is usually the joystick axis because a smaller positive/fabs raw value crosses 0.5. However, if you pull the trigger fast enough and EE is slow enough, the trigger can still win.
For example, this can result in the left trigger binding inconsistently as either
Axis 4orLeft triggeron Linux. The resulting behaviors are inconsistent, sinceAxis 4can exceed threshold at rest and hit its deadzone at half pressure, whileLeft triggerworks more as expected.To avoid this, skip SDL_JOY... events if the event is coming from a GameController device.