Track and block prohibited inputs for keybinds#308
Closed
oznogon wants to merge 1 commit into
Closed
Conversation
Add functions to track and prohibit input types and specific inputs from being assigned to keybinds, either globally or for a specific bind.
Owner
|
This feels extremely overly complicated. I think we just want to prevent people from binding mouse interactions in the keybinding menu, and still allow it from the config file for edge cases... |
Contributor
Author
|
I'd considered that, but without hooks in SP keybind reading there were edges where unwanted mouse inputs could still be set, even if we discarded the inputs for that functionality. I didn't want SP to have EE-specific checks, which would've been simpler than this. I'll make a more minimal EE-only workaround and leave the edge cases alone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add functions to track and prohibit input types and specific inputs from being assigned to keybinds, either globally or for a specific bind. Toward daid/EmptyEpsilon#2721 and required for daid/EmptyEpsilon#2806.
addGloballyProhibitedTypes()prohibits a mask of input types from assignment to all keybinds.addGloballyProhibitedKey()prohibits a specific input from assignment to all keybinds.addProhibitedTypes()prohibits a mask of input types from assignment to a specific keybind.addProhibitedKey()prohibits a specific input from assignment to a specific keybind.isInputAllowed()returns true if an input is not prohibited.