Skip to content

feat: game center#5773

Draft
AmarTrebinjac wants to merge 11 commits intomainfrom
ENG-1109
Draft

feat: game center#5773
AmarTrebinjac wants to merge 11 commits intomainfrom
ENG-1109

Conversation

@AmarTrebinjac
Copy link
Contributor

@AmarTrebinjac AmarTrebinjac commented Mar 22, 2026

Changes

Events

Did you introduce any new tracking events?

Experiment

Did you introduce any new experiments?

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

Preview domain

https://eng-1109.preview.app.daily.dev

@vercel
Copy link

vercel bot commented Mar 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
daily-webapp Ready Ready Preview Mar 24, 2026 9:14am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
storybook Ignored Ignored Mar 24, 2026 9:14am

Request Review

@AmarTrebinjac
Copy link
Contributor Author

@claude please solve the merge conflict if it is trivial to solve, otherwise alert me and I'll solve it myself

@claude
Copy link
Contributor

claude bot commented Mar 23, 2026

Claude finished @AmarTrebinjac's task in 1m 33s —— View job


Merge conflict resolved

  • Check current branch status and identify conflicts
  • Assess if conflicts are trivial
  • Resolve conflicts and push

There was one trivial conflict in packages/shared/src/components/quest/QuestButton.tsx:

// HEAD (ENG-1109):
await router.push(getQuestDestinationHref(destination.path));

// origin/main:
await router.push(`${webappUrl}${destination.path.replace(/^\//, '')}`);

Resolution: Kept the ENG-1109 version (getQuestDestinationHref), which is a superset of the main version — it handles absolute URLs and the root / path in addition to the same logic main inlined. The merge commit has been pushed.

Resolved conflict in QuestButton.tsx: kept getQuestDestinationHref helper
(introduced in this branch) over the inlined version from main, as it
handles absolute URLs and the root '/' path as edge cases.

Co-authored-by: Amar Trebinjac <AmarTrebinjac@users.noreply.github.com>
@AmarTrebinjac
Copy link
Contributor Author

@claude undo that change and keep the main one

@claude
Copy link
Contributor

claude bot commented Mar 23, 2026

Claude finished @AmarTrebinjac's task in 1m 6s —— View job


Reverted QuestButton to origin/main version

  • Read current state of QuestButton.tsx
  • Revert to origin/main version
  • Commit and push

Removed the getQuestDestinationHref helper and restored the inline template literal from main:

await router.push(`${webappUrl}${destination.path.replace(/^\//, '')}`);

Co-authored-by: Amar Trebinjac <AmarTrebinjac@users.noreply.github.com>
@AmarTrebinjac
Copy link
Contributor Author

@claude fix the build issues

@claude
Copy link
Contributor

claude bot commented Mar 23, 2026

Claude finished @AmarTrebinjac's task in 17m 1s —— View job


Build issues fixed

  • Identify root causes via next lint
  • Fix Prettier formatting error in pages/game-center/index.tsx
  • Fix lib/gameCenter.spec.ts not in tsconfig.eslint.json
  • Commit and push

Two root causes found and fixed:

  1. Prettier formattingpages/game-center/index.tsx lines 660–666 had incorrect line wrapping in a JSX text block. Fixed with eslint --fix.

  2. Missing tsconfig entrylib/gameCenter.spec.ts was placed in lib/ (alongside its source file), but tsconfig.eslint.json didn't include lib/**/*.ts. This caused next lint (and therefore next build) to fail with:

    Parsing error: "parserOptions.project" has been set for @typescript-eslint/parser.
    The file does not match your project config: lib/gameCenter.spec.ts.
    

    Fixed by adding "lib/**/*.ts" and "lib/**/*.tsx" to tsconfig.eslint.json.

next lint --no-cache now passes cleanly ✔
| Branch: ENG-1109

- Fix Prettier formatting in pages/game-center/index.tsx (line wrap)
- Add lib/**/*.ts to tsconfig.eslint.json so next lint can parse gameCenter.spec.ts

Co-authored-by: Amar Trebinjac <AmarTrebinjac@users.noreply.github.com>
@AmarTrebinjac
Copy link
Contributor Author

@claude fix lint

@claude
Copy link
Contributor

claude bot commented Mar 23, 2026

Claude finished @AmarTrebinjac's task in 8m 14s —— View job


Lint fixed

  • Gather context and understand the request
  • Run lint to identify current issues
  • Fix lint issues
  • Commit and push

One Prettier formatting error in packages/shared/src/graphql/users.spec.ts:5 — a long .toContain(...) call that needed to be wrapped across lines. Fixed and pushed.
| Branch: ENG-1109

Co-authored-by: Amar Trebinjac <AmarTrebinjac@users.noreply.github.com>
@AmarTrebinjac AmarTrebinjac changed the title feat: hub page feat: game center Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant