Conversation
…ia JS CF5 renders complex fields with React. An html-type field inside a complex field's add_fields() crashes the React renderer when "Add Entry" is clicked, causing the entire distribution group to disappear. Fix: remove byte_size_ui html field from the complex field definition and the now-unused get_filesize_widget_html() PHP method. The composite filesize widget (number + unit dropdown) is now built and inserted dynamically by odw-admin-fields.js next to the hidden backing input ([data-odw-backing="byte_size"]). Translated strings are passed via wp_localize_script (odwAdminFields.fileSizeWidget). https://claude.ai/code/session_FEyiS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Clicking "Add Entry" in Tab 3 (Datenbereitstellung) caused the entire distribution field to disappear. Root cause: CF5 renders complex fields with React, and an
html-type field insideadd_fields()crashes the React renderer when a new entry is added.Fix
Field::make('html', 'byte_size_ui')and the now-unusedget_filesize_widget_html()PHP method from the complex field definitionodw-admin-fields.js, adjacent to the hidden[data-odw-backing="byte_size"]inputwp_localize_script(odwAdminFields.fileSizeWidget)input[data-odw-backing="byte_size"]in newly added nodes (instead of.odw-filesize-widget)Test plan
https://claude.ai/code/session_FEyiS
Generated by Claude Code