Fixed the test build on linux#260
Merged
anasdorbani merged 10 commits intoApr 9, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the unit test build linkage to address Linux build issues and adjusts the GitHub Actions workflow so the main distribution pipeline also runs for pull requests.
Changes:
- Update unit test target link libraries (including linking
duckdb_staticand adjusting link order). - Enable
MainDistributionPipeline.ymlto run onpull_requestevents in addition topush.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
test/unit/CMakeLists.txt |
Adds duckdb_static (and reorders dependencies) when linking the unit test executable to improve Linux test build/link reliability. |
.github/workflows/MainDistributionPipeline.yml |
Adds a pull_request trigger so the distribution pipeline executes on PRs, not only on pushes to main/dev. |
Comment on lines
5
to
8
| on: | ||
| pull_request: | ||
| push: | ||
| branches: |
There was a problem hiding this comment.
The new pull_request trigger is unfiltered (no branches/paths), so this distribution pipeline will run for every PR, including doc-only or unrelated changes. If the intent is just to validate extension-related changes, consider adding the same paths (and optionally branches) filters as the push trigger to avoid unnecessary CI load/time.
anasdorbani
force-pushed
the
bugfix/linux-test-build
branch
from
ed92c68 to
63e8093
Compare
anasdorbani
force-pushed
the
bugfix/linux-test-build
branch
from
63e8093 to
06ba9a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.