Bump duckdb to v1.5.1#264
Conversation
… icon to documentation. (#253)
There was a problem hiding this comment.
Pull request overview
Updates CI configuration and internal contributor guidance to target DuckDB/extension-ci-tools v1.5.1, and enables the main distribution workflow to run on pull requests.
Changes:
- Trigger the main distribution workflow on
pull_requestevents. - Bump referenced
duckdb/extension-ci-toolsreusable workflows and inputs fromv1.5.0tov1.5.1. - Update
.github/copilot-instructions.mdto reflect the new targeted DuckDB version.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/MainDistributionPipeline.yml |
Runs CI on PRs and updates DuckDB/CI tools versions to v1.5.1. |
.github/copilot-instructions.md |
Updates stated targeted DuckDB/CI tools version to v1.5.1. |
| duckdb-stable-build: | ||
| name: Build extension binaries | ||
| uses: duckdb/extension-ci-tools/.github/workflows/_extension_distribution.yml@v1.5.0 | ||
| uses: duckdb/extension-ci-tools/.github/workflows/_extension_distribution.yml@v1.5.1 | ||
| with: | ||
| duckdb_version: v1.5.0 | ||
| ci_tools_version: v1.5.0 | ||
| duckdb_version: v1.5.1 | ||
| ci_tools_version: v1.5.1 |
There was a problem hiding this comment.
PR title indicates DuckDB is being bumped to v1.5.1, but this PR only updates the CI workflow inputs (and the referenced extension-ci-tools workflow tag). If the intent is to bump the repository’s DuckDB submodule/pinned source as well, that change is missing; otherwise consider adjusting the PR title/description to reflect that this is a CI/tooling bump only.
| - **Dependency manager**: vcpkg (managed via `vcpkg.json`) | ||
| - **Key dependencies**: `nlohmann-json`, `curl`, `gtest` (see `vcpkg.json`) | ||
| - **DuckDB version targeted**: v1.5.0 (see `MainDistributionPipeline.yml`) | ||
| - **DuckDB version targeted**: v1.5.1 (see `MainDistributionPipeline.yml`) | ||
|
|
There was a problem hiding this comment.
This file now states the targeted DuckDB version is v1.5.1, but other repository docs still mention v1.5.0 (e.g., README.md:83 and custom-instructions/repo/.github/copilot-instructions.md:11,115). To avoid conflicting guidance, update the remaining references (or clarify which one is authoritative).
No description provided.