Add sparsego#439
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #439 +/- ##
===============================================
- Coverage 80.34% 77.97% -2.37%
===============================================
Files 101 106 +5
Lines 8171 8860 +689
===============================================
+ Hits 6565 6909 +344
- Misses 1606 1951 +345 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
This should not be in this PR :)
| input_type = self.hyperparameters.get("input_type", "expression") | ||
| feature_type = "gene_expression" if input_type == "expression" else "mutations" | ||
|
|
||
| cell_line_features = load_and_select_gene_features( |
There was a problem hiding this comment.
With gene_list=None, load_and_select_gene_features returns all genes from gene_expression.csv in order of the CSV, not just the ontology genes, and not in gene2ind.txt order. The model is then trained on the wrong inputs I think. Could you check this?
PR Checklist for all PRs
New features
Added SparseGO model for drug response prediction based
drevalpy/models/SparseGO/— model implementation (sparse VNN + drug ANN)drevalpy/datasets/featurizer/create_sparsego_features.py— featurizer to generate GO ontology input filesMODEL_FACTORY, hyperparameters from the original paper, optional dependenciesmygeneandobonetadded