Modify name table to pass more fontbakery checks#42
Open
madig wants to merge 1 commit intodaltonmaag:masterfrom
Open
Modify name table to pass more fontbakery checks#42madig wants to merge 1 commit intodaltonmaag:masterfrom
madig wants to merge 1 commit intodaltonmaag:masterfrom
Conversation
1. Delete openTypeNameDescription as it was deemed too long. 2. Change openTypeNameDesigner and openTypeNameManufacturer to "Dalton Maag Limited", as that is what the vendor id DAMA resolves to officially. 3. Insert openTypeNameLicense and openTypeNameLicenseURL. More modifications are necessary.
sladen
reviewed
Dec 28, 2017
| <integer>693</integer> | ||
| <key>copyright</key> | ||
| <string>Copyright 2011 Canonical Ltd. Licensed under the Ubuntu Font Licence 1.0</string> | ||
| <string>Copyright 2011 Canonical Ltd.</string> |
Collaborator
There was a problem hiding this comment.
Probably useful to leave the libre licence for the moment. It is included in the GF release, so changing this would increase the diff size.
| <key>openTypeNameDescription</key> | ||
| <string>The Ubuntu Font Family are libre fonts funded by Canonical Ltd on behalf of the Ubuntu project. The font design work and technical implementation is being undertaken by Dalton Maag. The typeface is sans-serif, uses OpenType features and is manually hinted for clarity on desktop and mobile computing screens. | ||
|
|
||
| The scope of the Ubuntu Font Family includes all the languages used by the various Ubuntu users around the world in tune with Ubuntu's philosophy which states that every user should be able to use their software in the language of their choice. The project is ongoing, and we expect the family will be extended to cover many written languages in the coming years.</string> |
Collaborator
There was a problem hiding this comment.
Perhaps better to replace this with something shorter, than simply delete it wholesale.
Contributor
Author
There was a problem hiding this comment.
Mind you, that would increase the diff, as the GF version has it deleted, too.
Collaborator
There was a problem hiding this comment.
Should be enough to just
<!--
comment it out
-->on the lines before/after. Nice small diff, same effect.
Contributor
Author
There was a problem hiding this comment.
ufonormalizer then kills it dead :D
| The scope of the Ubuntu Font Family includes all the languages used by the various Ubuntu users around the world in tune with Ubuntu's philosophy which states that every user should be able to use their software in the language of their choice. The project is ongoing, and we expect the family will be extended to cover many written languages in the coming years.</string> | ||
| <key>openTypeNameDesigner</key> | ||
| <string>Dalton Maag Ltd</string> | ||
| <string>Dalton Maag Limited</string> |
Collaborator
There was a problem hiding this comment.
Might be better to fix this upstream by teaching the checker that "Ltd" is an abbreviation of "Limited".
Collaborator
|
Can we split this into what is useful for reaching baseline parity vs. what is useful for making FontBakery happier? |
Contributor
Author
|
The only real baseline change would be to remove the description. The other diffs to baseline are:
|
Collaborator
|
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maag Limited", as that is what the vendor id DAMA resolves to
officially.
More modifications are necessary: should openTypeNameLicense spell out the entire license text?