Skip to content

ci: ignore HACS license check until a license is chosen - #38

Merged
dalyem merged 1 commit into
masterfrom
ci/ignore-hacs-license-check
Jul 7, 2026
Merged

ci: ignore HACS license check until a license is chosen#38
dalyem merged 1 commit into
masterfrom
ci/ignore-hacs-license-check

Conversation

@dalyem

@dalyem dalyem commented Jul 7, 2026

Copy link
Copy Markdown
Owner

Summary

Every push to master and every in-repo PR currently fails the hacs job with "The repository has no license" — including the two master pushes from today's merges. Fork PRs (like #32/#33) run a reduced HACS check set, which is why this never surfaced before.

The repo has never had a LICENSE file, and neither does the upstream Memberapple fork it derives from — so choosing a license is a maintainer decision I'm deliberately not making here (note the README's License section is also a no-warranty statement rather than a grant). This one-liner tells hacs/action to skip the license validation so CI reflects the actual state of the code.

Follow-up for @dalyem

Pick and commit a license when you get a chance (MIT is the common choice for HA custom integrations — but since the upstream fork was unlicensed, whether/how to license is your call), then delete the ignore: license line. HACS docs on the requirement: https://hacs.xyz/docs/publish/include#check-license

Verification

After merging, the hacs job on master pushes and in-repo PRs should pass again (8/8 remaining checks were already green — only license fails today).

🤖 Generated with Claude Code

The repository (like the upstream fork it derives from) has no LICENSE
file. hacs/action runs its full check suite for in-repo refs, so every
push to master and every in-repo PR fails the license validation, while
fork PRs skip it - which is why CI looked green until today. Ignore the
check explicitly so CI reflects the state of the code; drop this once a
license is committed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@dalyem, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 31 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5e31987d-03e1-442d-a752-a66a2c0fdd35

📥 Commits

Reviewing files that changed from the base of the PR and between 67e7442 and 5f70e35.

📒 Files selected for processing (1)
  • .github/workflows/validate.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/ignore-hacs-license-check

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dalyem
dalyem merged commit 8ae0cbd into master Jul 7, 2026
6 checks passed
dalyem added a commit that referenced this pull request Jul 7, 2026
Adds the standard MIT license (the common choice for Home Assistant
custom integrations) covering the fork's history, points the README's
License section at it, and removes the temporary ignore added in #38 so
hacs/action validates the license again.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@dalyem

dalyem commented Jul 7, 2026

Copy link
Copy Markdown
Owner Author

Follow-up complete: the repository is now MIT-licensed (b2483e6, pushed to master) and the temporary ignore: license line added here has been removed. GitHub detects the license (spdx_id: MIT) and the first master run with the check re-enabled is green: hacs ✅ hassfest ✅ — https://github.com/dalyem/ha_aromalink/actions/runs/28844771797

@dalyem
dalyem deleted the ci/ignore-hacs-license-check branch July 14, 2026 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant