Repository navigation
feat: scan-to-import unknown deck flow - #26
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/deck-pointer.ts—reconstructPlaylistUrl(DZ → canonical Deezer URL; other providers → null) anddeckMatchesPointer(matches by parsed Deezer playlist id, robust to legacy/foreign sourceUrls)lib/import-session.ts— module-levelSetof declined pointers; cleared on app relaunch per AC's "during the session"app/import.tsx— prompt screen: fetches playlist metadata viaextractFromDeezerUrl, shows playlist name + track count, primary "Import this deck" →/resolving?url=...(reuses YearResolver + Cache + RateLimiter + DeckGenerator with Resolving screen #4 pipeline), outline "Not now" →markDeclinedthen/app/playback.tsxend-of-round logic branches on parsed code: extended+unknown → prompt; extended+known →/scan; extended+declined →/scan; legacy bare ISRC →/scan. Import never auto-runs without explicit user tap. Anti-spoiler discipline preserved (existence-only Library check, no track strings)Test plan
npm test— 140 pass (9 new for deck-pointer)npm run typecheckcleannpm run lintclean