Repository navigation
feat(deck): unify deck page with drops-aware UI - #34
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30
Summary
app/deck/[id].tsxwith the unified deck page (lifted fromapp/review/[id].tsx); deleted thereview/[id]route. Library entry and post-generation flow now both land on the same screen.InlineAlerts, kept/skipped filter pills, dropped-tracks list, "X cards · Y skipped" subtitle) render purely asdrops.length > 0conditionals — no mode flag, no route param. When opened from the library the store is empty for that id, so all the enhancements short-circuit and the screen falls back to a plain card list with a "X cards · created Mon DD, YYYY" subtitle.headerBackVisible: falseandgestureEnabled: falsefrom the page'sStack.Screenoptions; removed the hardcoded title from the layout-leveldeck/[id]entry so the in-screenheaderTitle(driven bydeck.name) wins.app/resolving.tsxredirect from/review/${id}to/deck/${id}.YearEditornow dismisses without committing on Android hardware back (viaBackHandler.addEventListener('hardwareBackPress', …)whileeditingIsrc != null) and on tap outside (viaKeyboard.addListener('keyboardDidHide', …)— the existingkeyboardShouldPersistTaps="handled"on theFlatListcollapses the soft keyboard on tap-outside, which we mirror to clear the edit state).Test plan
npm run typecheckcleannpm run lintcleannpm test— 140/140 pass/deck/[id]with drops UI (subtitle "X cards · Y skipped", InlineAlerts, filter pills, dropped rows visible)/deck/[id]with the same screen but no drops UI; subtitle reads "X cards · created Mon DD, YYYY"