Repository navigation
feat(deck): header menu with rename and delete - #35
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #31.
Summary
deckLibrary.updateName(id, name)method (mirrors the existing read-modify-write pattern used byupdateYearOverride, gated by the per-key write lock).ellipsis-verticalbutton to the unified deck page'sheaderRight, after the existing Export PDF button.TextInputpre-filled with the current name, trims before commit, refuses empty input, and on success updates the in-screenstate.deckso the header title re-renders without a full reload.Alert.alertwith destructive style, same copy), thendeckLibrary.delete(id)androuter.replace('/').Test plan
npm run typecheck— cleannpm run lint— cleannpm test— 145 pass (143 baseline + 2 newDeckLibrary.updateNametests)/