Skip to content

Do not add quotes for input filename, breaks plenty of file paths #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anselanza wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Do not add quotes for input filename, breaks plenty of file paths #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01b5f72
do not add quotes, breaks plenty of file paths
Nov 15, 2021
55b5ac3
video.js must have no quotes added
Nov 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ffmpeg.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ var ffmpeg = function (/* inputFilepath, settings, callback */) {
// New 'promise' instance
var deferred = when.defer();
// Make the call to retrieve information about the ffmpeg
utils.exec([ffmpeg.bin,'-i', utils.addQuotes(fileInput),'2>&1'], settings, function (error, stdout, stderr) {
utils.exec([ffmpeg.bin,'-i', fileInput,'2>&1'], settings, function (error, stdout, stderr) {
// Perse output for retrieve the file info
var filename = /from \'(.*)\'/.exec(stdout) || []
, title = /(INAM|title)\s+:\s(.+)/.exec(stdout) || []
Expand Down
2 changes: 1 addition & 1 deletion lib/video.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,7 +557,7 @@ module.exports = function (filePath, settings, infoConfiguration, infoFile) {
}
// Create a copy of the commands list
var finalCommands = ['ffmpeg -i']
.concat(inputs.map(utils.addQuotes).join(' -i '))
.concat(inputs.join(' -i '))
.concat(commands.join(' '))
.concat(filtersComlpex.length > 0 ? ['-filter_complex "'].concat(filtersComlpex.join(', ')).join('') + '"' : [])
.concat([output]);
Expand Down