Skip to content

Fix the two CI test failures left after the v0.9.1 sync - #120

Merged
damiantw merged 1 commit into
mainfrom
fix-ci-after-f9456e8
Nov 9, 2026
Merged

damiantw merged 1 commit into
mainfrom
fix-ci-after-f9456e8

Conversation

@damiantw

@damiantw damiantw commented Nov 9, 2026

Copy link
Copy Markdown
Owner

Follow-up to #119. Test-only changes; no runtime, shader or emitter code changes.

test_sh2_discovery test_instruction_hook_survives_a_direct_internal_branch
The fork's cycle model (runtime-diagnostics.patch, emit.py) opens every block, including a branch target's label, with a prologue of SH2_STATE_POINT/SH2_CYC/SH2_CYC2/SH2_BLK before the first instruction. The hook is still appended to the hooked instruction (c.r[5] = 0x1u; sh2_hook(c, 0x06000006u);), which is the documented after-instruction placement and is reached on the goto path. The emitter is correct; the regex now allows the block prologue, pins the hooked statement, and checks that there is exactly one hook. It still passes against an emitter with no cycle model.

gpu_renderer_selftest "High-resolution floor must retain sprite colour-calculation order"
Upstream's new case (a366075) expects the sprite red channel as 0xFF (5-bit values with replicated low bits). The fork's geometry.hlsl expands RGB dots the way VDP2 and the CPU compositor do (shifted left by 3, no replication), and every other case in this file already expects 0xF8. The expectation is updated to 0xF80000. The trailing SDL: Render target texture is NULL in the failure was a stale SDL_GetError() string, not the cause.

Local (Linux, clang, lavapipe llvmpipe 19.1.7): gpu_renderer_selftest PASS (213 cases), image_scaler_selftest --gpu PASS, gpu_parity PASS, Python 338 run OK (4 skipped), source audit PASS (293 files).

test_sh2_discovery: the fork's cycle model opens every block, including a
branch target's label, with a prologue (SH2_STATE_POINT/SH2_CYC/SH2_CYC2/
SH2_BLK) before its first instruction. The hook is still emitted after the
hooked instruction on the branch path, which is the intended placement, so
the regex now allows the block prologue and pins the hooked statement.

gpu-renderer: upstream's new high-resolution floor case (a366075) expected
the sprite red as 0xFF, from replicated low bits. The fork's geometry shader
expands RGB dots as VDP2 does (5 bits shifted left by 3, no replication), as
every other case in this file already expects, so the sprite channel is 0xF8.
The trailing "Render target texture is NULL" was a stale SDL_GetError string,
not the cause.
@damiantw
damiantw merged commit d7b54c4 into main Nov 9, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant