Open
Conversation
added 2 commits
May 20, 2015 18:41
Was previously getting components from a mixture of locations - CDNs, github and the local bower_components - despite everything being available locally in bower_components. I updated it to source everything from the local bower_components folder This is more consistent and ensures that the demo is using the correct versions of all components, rather than a mixture.
- Move the Cancel, Delete & Save buttons out into a variable, and use this in the templates, instead of duplicating this in every template. - Improve the markup & style of the buttons; use words instead of icons for Saev & Delete - simpler, cleaner and larger tap/click targets. - Add an 'x' button at the top right to close/cancel the popover; keep Cancel button for now. - Improve the scss for the buttons & popovers in general; min-height for the contents, to minimize jumping around; tidy up & improve margins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modularize & improve the popover templates
use this in the templates, instead of duplicating this in every template.
Save & Delete - simpler, cleaner and larger tap/click targets.
Cancel button for now.
the contents, to minimize jumping around; tidy up & improve margins.
This is an example what they look like now: