Skip to content

feat(tools): stop a grep between files when the turn is stopped - #516

Open
danczw wants to merge 4 commits into
mainfrom
feat/26-cancel-grep
Open

danczw wants to merge 4 commits into
mainfrom
feat/26-cancel-grep

Conversation

@danczw

@danczw danczw commented Nov 12, 2026 •

Copy link
Copy Markdown
Owner

#26 grep only: it checks the cancel token before each file and returns Cancelled, never a marked partial listing. find, read, ls, write and edit stay uncancellable and #26 stays open: none has a safe point whose stop is worth the partial state or the wider sandbx-core API.

A stopped call now reads "cancelled" and not "cancelled and killed", since only a bash is killed.

SECURITY.md changed: the interrupt bullet and the session-store bullet name grep and say the walk before it and the read inside a file are not interruptible.

Reviews, all over origin/main...HEAD from the worktree: /code-review at 6ecd945 (6 files, +72/-18), /security-review at 3ff1af0 (10 files, +86/-28), no findings. Comment pass at 1b6370a (10 files, +88/-29), code unchanged by it.

@danczw danczw added this to the v0.1.0-alpha.26 milestone Nov 12, 2026
@danczw danczw added enhancement New feature or request crate:tools the seven built-in tools, each confined by core crate:turn the turn loop labels Nov 12, 2026
@danczw danczw self-assigned this Nov 12, 2026
@danczw
danczw marked this pull request as ready for review November 12, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

crate:tools the seven built-in tools, each confined by core crate:turn the turn loop enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant