Repository navigation
Conversation
danczw
marked this pull request as ready for review
November 12, 2026 13:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#26
greponly: it checks the cancel token before each file and returnsCancelled, never a marked partial listing.find,read,ls,writeandeditstay uncancellable and #26 stays open: none has a safe point whose stop is worth the partial state or the widersandbx-coreAPI.A stopped call now reads "cancelled" and not "cancelled and killed", since only a
bashis killed.SECURITY.mdchanged: the interrupt bullet and the session-store bullet namegrepand say the walk before it and the read inside a file are not interruptible.Reviews, all over
origin/main...HEADfrom the worktree:/code-reviewat 6ecd945 (6 files, +72/-18),/security-reviewat 3ff1af0 (10 files, +86/-28), no findings. Comment pass at 1b6370a (10 files, +88/-29), code unchanged by it.