fix: improve ANSI black/brightBlack contrast for readability#7
Merged
Conversation
Adds minimum contrast checks against base background: - ansi.black: 2:1 minimum - ansi.brightBlack: 3:1 minimum Palette currently fails — fixed in next commit.
black: #1e1a2c (1.11:1) → #4c4862 (~2.2:1) brightBlack: #302c42 (1.4:1) → #68647e (~3.3:1) Both were nearly invisible against the base background (#12101e). New values stay in the purple-gray family while being legible. Closes #6
Owner
Author
|
Thanks @mesalilac for the detailed report and screenshots — great catch! The fix bumps both ANSI black values into readable range and adds contrast validation so this can't regress. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
blackandbrightBlackwere nearly invisible as foreground text against the base background (#12101e)black:#1e1a2c(1.11:1) →#56526c(~2.5:1)brightBlack:#302c42(1.4:1) →#68647e(~3.3:1)Closes #6
Test plan
bun test)bun run generate)bun run check)