fix: add missing VS Code context menu and UI colors#9
Merged
Conversation
Owner
Author
|
Thanks again @mesalilac for catching this! While fixing the context menu, we also audited the full VS Code theme and added ~25 other missing UI color definitions (toolbar, keybinding labels, settings UI, sticky scroll, etc.). Appreciate you helping us improve the theme! |
danfry1
force-pushed
the
fix/vscode-context-menu
branch
from
4bc15e7 to
a408dd3
Compare
Adds context menu colors (menu.*) to fix invisible selection state during keyboard navigation, plus additional missing UI colors: - menu.* — context menu background, selection, border - toolbar.* — hover/active states for toolbar buttons - keybindingLabel.* — keybinding badge styling in menus - sash.hoverBorder — resize handle visibility - editorStickyScroll.* — sticky scroll header backgrounds - editorGutter.foldingControlForeground — code folding arrows - tab.lastPinnedBorder — pinned tab separator - button.secondaryHoverBackground — secondary button hover - notificationToast.border — toast notification border - settings.* — settings UI inputs, checkboxes, dropdowns Closes #8
danfry1
force-pushed
the
fix/vscode-context-menu
branch
from
a408dd3 to
6734db8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
menu.*color definitions to fix invisible context menu selection state during keyboard navigationAll new colors follow existing palette conventions (surface0 for backgrounds, surface1 for selections, surface2 for borders, lavender for accents).
Thanks @mesalilac for reporting this!
Closes #8
Test plan
bun test)bun run generate)bun run check)