feat: step-level caching, async hooks, onRunComplete output#27
feat: step-level caching, async hooks, onRunComplete output#27brianjenkins94 wants to merge 4 commits into
Conversation
Addresses interrelated issues danfry1#21, danfry1#23, danfry1#24.
…c createEngine _createEngine becomes the internal implementation. The public createEngine supports both single-workflow (enqueue infers name) and multi-workflow (enqueue requires name) forms with full type inference preserved.
f76cf46 to
5f654af
Compare
|
Hey Brian — really nice draft. After shipping #31 I went back through this and I think there's a strong case for splitting out the async hooks change (#23) into its own small PR rather than landing all three together. Wanted to lay out exactly what we'd want in scope and offer to collaborate on it. Why split
Splitting also means we get #23 in front of users faster and you get a clean merge while we continue the conversation on the other two. What we'd want in the #23 PRIn scope:
Out of scope (defer to their own PRs):
One small heads-up: #31 merged a parallel-execution path that adds two new CollaborationHappy to:
Either way, your call. Whatever's least friction for you. Thanks again for putting all this together — the test coverage on the hook failure modes is really thoughtful. |
|
No problem, I just needed all these things so I thought I'd take a stab at it. It'll probably be a couple weeks before I have time to work on this again, so don't let me hold you up if you want to build this out. |
Addresses interrelated issues #21, #23, #24. More detail to come.