feat: like/unlike tracks from TUI#6
Merged
Merged
Conversation
The ncspot client ID has "/login" registered in Spotify's dashboard. This fix was in v1.2.1 but was lost during the git history cleanup for v1.2.2. Restores the callbackPath() function that returns "/login" for the default client ID and "/callback" for custom client IDs. Fixes #2
Without this, navigating to Liked Songs after saving a track would show stale cached data until the 5-minute TTL expired.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fkeybinding and context actions menu (o)♥in status bar and now-playing overlay when the current track is likeduser-library-modifyOAuth scope (existing users need to re-runwaxon auth)Also restores the auth callback path fix from v1.2.1 that was lost during the v1.2.2 history cleanup — uses
/loginfor the default ncspot client ID and/callbackfor custom client IDs.Test plan
waxon authto pick up the new scopefon a track in the tracklist — toast shows "Saved to Liked Songs"fagain on the same track while playing — toast shows "Removed from Liked Songs"♥appears/disappears in status bar when playing a liked trackNthenf— like works from now-playing overlayoon a track — context menu shows "Save to Liked Songs" / "Remove from Liked Songs"?— help showsf favouritein ACTIONSwaxon authworks without redirect_uri mismatch (ncspot client ID fix)